2020-11-27 16:09:59

by Manivannan Sadhasivam

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: qcom: Fix IRQ error misassignement

On Fri, Nov 27, 2020 at 02:39:37PM +0100, Robert Foss wrote:
> During cci_isr() errors read from register fields belonging to
> i2c master1 are currently assigned to the status field belonging to
> i2c master0. This patch corrects this error, and always assigns
> master1 errors to the status field of master1.
>
> Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
>

You don't need a new line here.

> Reported-by: Loic Poulain <[email protected]>
> Suggested-by: Loic Poulain <[email protected]>
> Signed-off-by: Robert Foss <[email protected]>

Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks,
Mani


2020-11-30 10:09:17

by Robert Foss

[permalink] [raw]
Subject: Re: [PATCH v2] i2c: qcom: Fix IRQ error misassignement

On Fri, 27 Nov 2020 at 17:06, Manivannan Sadhasivam
<[email protected]> wrote:
>
> On Fri, Nov 27, 2020 at 02:39:37PM +0100, Robert Foss wrote:
> > During cci_isr() errors read from register fields belonging to
> > i2c master1 are currently assigned to the status field belonging to
> > i2c master0. This patch corrects this error, and always assigns
> > master1 errors to the status field of master1.
> >
> > Fixes: e517526195de ("i2c: Add Qualcomm CCI I2C driver")
> >
>
> You don't need a new line here.

Ack

>
> > Reported-by: Loic Poulain <[email protected]>
> > Suggested-by: Loic Poulain <[email protected]>
> > Signed-off-by: Robert Foss <[email protected]>
>
> Reviewed-by: Manivannan Sadhasivam <[email protected]>

Thanks for the review!