2021-05-12 06:30:55

by Zou Wei

Subject: [PATCH -next] drm/bridge: lt9611: Add missing MODULE_DEVICE_TABLE

This patch adds missing MODULE_DEVICE_TABLE definition which generates
correct modalias for automatic loading of this driver when it is built
as an external module.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/gpu/drm/bridge/lontium-lt9611.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
index e8eb8de..29b1ce2 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
@@ -1215,6 +1215,7 @@ static struct i2c_device_id lt9611_id[] = {
{ "lontium,lt9611", 0 },
{}
};
+MODULE_DEVICE_TABLE(i2c, lt9611_id);

static const struct of_device_id lt9611_match_table[] = {
{ .compatible = "lontium,lt9611" },
--
2.6.2

2021-05-17 13:51:44

by Robert Foss

Subject: Re: [PATCH -next] drm/bridge: lt9611: Add missing MODULE_DEVICE_TABLE

Hey Zou,

On Wed, 12 May 2021 at 08:29, Zou Wei <[email protected]> wrote:
>
> This patch adds missing MODULE_DEVICE_TABLE definition which generates
> correct modalias for automatic loading of this driver when it is built
> as an external module.
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611.c b/drivers/gpu/drm/bridge/lontium-lt9611.c
> index e8eb8de..29b1ce2 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611.c
> @@ -1215,6 +1215,7 @@ static struct i2c_device_id lt9611_id[] = {
> { "lontium,lt9611", 0 },
> {}
> };
> +MODULE_DEVICE_TABLE(i2c, lt9611_id);
>
> static const struct of_device_id lt9611_match_table[] = {
> { .compatible = "lontium,lt9611" },
> --
> 2.6.2
>

This looks good to me, I've picked this change into drm-misc-next.

https://cgit.freedesktop.org/drm/drm-misc/commit/?id=8d0b1fe81e18eb66a2d4406386760795fe0d77d9