2022-05-26 03:00:48

by Laurent Pinchart

Subject: Re: [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'

Hi Rob,

Thank you for the patch.

On Wed, May 25, 2022 at 03:56:26PM -0500, Rob Herring wrote:
> While 'ddc-i2c-bus' is a common property, it should be in a connector
> node rather than the HDMI bridge node as the I2C bus goes to a
> connector and not the HDMI block. Drop it from the example.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> index b8219eab4475..89490fdffeb0 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> @@ -55,7 +55,6 @@ examples:
> compatible = "ingenic,jz4780-dw-hdmi";
> reg = <0x10180000 0x8000>;
> reg-io-width = <4>;
> - ddc-i2c-bus = <&i2c4>;
> interrupt-parent = <&intc>;
> interrupts = <3>;
> clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;

--
Regards,

Laurent Pinchart

2022-05-27 09:22:42

by Robert Foss

Subject: Re: [PATCH] dt-bindings: display: ingenic,jz4780-hdmi: Drop undocumented 'ddc-i2c-bus'

On Thu, 26 May 2022 at 00:34, Laurent Pinchart
<[email protected]> wrote:
>
> Hi Rob,
>
> Thank you for the patch.
>
> On Wed, May 25, 2022 at 03:56:26PM -0500, Rob Herring wrote:
> > While 'ddc-i2c-bus' is a common property, it should be in a connector
> > node rather than the HDMI bridge node as the I2C bus goes to a
> > connector and not the HDMI block. Drop it from the example.
> >
> > Signed-off-by: Rob Herring <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>
>
> > ---
> > .../devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > index b8219eab4475..89490fdffeb0 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ingenic,jz4780-hdmi.yaml
> > @@ -55,7 +55,6 @@ examples:
> > compatible = "ingenic,jz4780-dw-hdmi";
> > reg = <0x10180000 0x8000>;
> > reg-io-width = <4>;
> > - ddc-i2c-bus = <&i2c4>;
> > interrupt-parent = <&intc>;
> > interrupts = <3>;
> > clocks = <&cgu JZ4780_CLK_AHB0>, <&cgu JZ4780_CLK_HDMI>;
>
> --
> Regards,
>
> Laurent Pinchart

Applied to drm-misc-next