2023-10-06 13:16:09

by Ross Lagerwall

[permalink] [raw]
Subject: Re: [PATCH] xen-netback: use default TX queue size for vifs

On Thu, Oct 5, 2023 at 3:08 PM Roger Pau Monne <[email protected]> wrote:
>
> Do not set netback interfaces (vifs) default TX queue size to the ring size.
> The TX queue size is not related to the ring size, and using the ring size (32)
> as the queue size can lead to packet drops. Note the TX side of the vif
> interface in the netback domain is the one receiving packets to be injected
> to the guest.
>
> Do not explicitly set the TX queue length to any value when creating the
> interface, and instead use the system default. Note that the queue length can
> also be adjusted at runtime.
>
> Fixes: f942dc2552b8 ('xen network backend driver')
> Signed-off-by: Roger Pau Monné <[email protected]>
> ---

Reviewed-by: Ross Lagerwall <[email protected]>