LinuxLists.cc - [PATCH v1] driver core: Release all resources during unbind before updating device links

2023-10-18 01:39:06

Subject: [PATCH v1] driver core: Release all resources during unbind before updating device links

This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
dependencies tracking support") where the device link status was
incorrectly updated in the driver unbind path before all the device's
resources were released.

Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
Reported-by: "Uwe Kleine-König" <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Signed-off-by: Saravana Kannan <[email protected]>
Cc: Thierry Reding <[email protected]>
Cc: Yang Yingliang <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Matti Vaittinen <[email protected]>
Cc: James Clark <[email protected]>
---
drivers/base/dd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index a528cec24264..0c3725c3eefa 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
if (dev->bus && dev->bus->dma_cleanup)
dev->bus->dma_cleanup(dev);

- device_links_driver_cleanup(dev);
device_unbind_cleanup(dev);
+ device_links_driver_cleanup(dev);

klist_remove(&dev->p->knode_driver);
device_pm_check_callbacks(dev);
--
2.42.0.655.g421f12c284-goog

2023-10-18 10:18:05

by Rafael J. Wysocki

[permalink] [raw]

Subject: Re: [PATCH v1] driver core: Release all resources during unbind before updating device links

On Wed, Oct 18, 2023 at 3:38 AM Saravana Kannan <[email protected]> wrote:
>
> This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
> dependencies tracking support") where the device link status was
> incorrectly updated in the driver unbind path before all the device's
> resources were released.
>
> Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
> Reported-by: "Uwe Kleine-König" <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Saravana Kannan <[email protected]>
> Cc: Thierry Reding <[email protected]>
> Cc: Yang Yingliang <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Matti Vaittinen <[email protected]>
> Cc: James Clark <[email protected]>

Acked-by: Rafael J. Wysocki <[email protected]>

> ---
> drivers/base/dd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index a528cec24264..0c3725c3eefa 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
> if (dev->bus && dev->bus->dma_cleanup)
> dev->bus->dma_cleanup(dev);
>
> - device_links_driver_cleanup(dev);
> device_unbind_cleanup(dev);
> + device_links_driver_cleanup(dev);
>
> klist_remove(&dev->p->knode_driver);
> device_pm_check_callbacks(dev);
> --
> 2.42.0.655.g421f12c284-goog
>

2023-10-18 10:41:39

by Uwe Kleine-König

[permalink] [raw]

Subject: Re: [PATCH v1] driver core: Release all resources during unbind before updating device links

Attachments:

(No filename) (1.75 kB)
signature.asc (499.00 B)
Download all attachments

2023-10-18 22:27:14

by Saravana Kannan

[permalink] [raw]

Subject: Re: [PATCH v1] driver core: Release all resources during unbind before updating device links

On Wed, Oct 18, 2023 at 3:40 AM Uwe Kleine-König
<[email protected]> wrote:
>
> On Tue, Oct 17, 2023 at 06:38:50PM -0700, Saravana Kannan wrote:
> > This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
> > dependencies tracking support") where the device link status was
> > incorrectly updated in the driver unbind path before all the device's
> > resources were released.
> >
> > Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
> > Reported-by: "Uwe Kleine-König" <[email protected]>
> > Closes: https://lore.kernel.org/all/[email protected]/
> > Signed-off-by: Saravana Kannan <[email protected]>
> > Cc: Thierry Reding <[email protected]>
> > Cc: Yang Yingliang <[email protected]>
> > Cc: Andy Shevchenko <[email protected]>
> > Cc: Mark Brown <[email protected]>
> > Cc: Matti Vaittinen <[email protected]>
> > Cc: James Clark <[email protected]>
> > ---
> > drivers/base/dd.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > index a528cec24264..0c3725c3eefa 100644
> > --- a/drivers/base/dd.c
> > +++ b/drivers/base/dd.c
> > @@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
> > if (dev->bus && dev->bus->dma_cleanup)
> > dev->bus->dma_cleanup(dev);
> >
> > - device_links_driver_cleanup(dev);
> > device_unbind_cleanup(dev);
> > + device_links_driver_cleanup(dev);
>
> Tested-by: Uwe Kleine-König <[email protected]>
> Acked-by: Uwe Kleine-König <[email protected]>
>
> This indeed fixes the crash I experinced before.

Thanks for the Tested-by!

-Saravana

2023-10-21 21:07:07

by Greg Kroah-Hartman

[permalink] [raw]

Subject: Re: [PATCH v1] driver core: Release all resources during unbind before updating device links

On Tue, Oct 17, 2023 at 06:38:50PM -0700, Saravana Kannan wrote:
> This commit fixes a bug in commit 9ed9895370ae ("driver core: Functional
> dependencies tracking support") where the device link status was
> incorrectly updated in the driver unbind path before all the device's
> resources were released.
>
> Fixes: 9ed9895370ae ("driver core: Functional dependencies tracking support")
> Reported-by: "Uwe Kleine-K?nig" <[email protected]>
> Closes: https://lore.kernel.org/all/[email protected]/
> Signed-off-by: Saravana Kannan <[email protected]>
> Cc: Thierry Reding <[email protected]>
> Cc: Yang Yingliang <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: Mark Brown <[email protected]>
> Cc: Matti Vaittinen <[email protected]>
> Cc: James Clark <[email protected]>
> ---
> drivers/base/dd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index a528cec24264..0c3725c3eefa 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -1274,8 +1274,8 @@ static void __device_release_driver(struct device *dev, struct device *parent)
> if (dev->bus && dev->bus->dma_cleanup)
> dev->bus->dma_cleanup(dev);
>
> - device_links_driver_cleanup(dev);
> device_unbind_cleanup(dev);
> + device_links_driver_cleanup(dev);
>
> klist_remove(&dev->p->knode_driver);
> device_pm_check_callbacks(dev);
> --
> 2.42.0.655.g421f12c284-goog
>

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
older released kernel, yet you do not have a cc: stable line in the
signed-off-by area at all, which means that the patch will not be
applied to any older kernel releases. To properly fix this, please
follow the documented rules in the
Documentation/process/stable-kernel-rules.rst file for how to resolve
this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot