2014-06-17 19:37:48

by Fabian Frédérick

Subject: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Ivo van Doorn <[email protected]>
Cc: Helmut Schaa <[email protected]>
Signed-off-by: Fabian Frederick <[email protected]>
---
drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
index 2bde672..c2c2300 100644
--- a/drivers/net/wireless/rt2x00/rt2x00dev.c
+++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
@@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
/*
* Free the driver data.
*/
- if (rt2x00dev->drv_data)
- kfree(rt2x00dev->drv_data);
+ kfree(rt2x00dev->drv_data);
}
EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);

--
1.8.4.5

2014-06-18 07:59:39

by Helmut Schaa

Subject: Re: [PATCH 1/1] drivers/net/wireless/rt2x00/rt2x00dev.c: remove null test before kfree

Hi,

On Tue, Jun 17, 2014 at 9:36 PM, Fabian Frederick <[email protected]> wrote:
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required

Thanks Fabian.
This should go through the wireless tree I guess, mind to send to
[email protected]?
Helmut

> Cc: Ivo van Doorn <[email protected]>
> Cc: Helmut Schaa <[email protected]>
> Signed-off-by: Fabian Frederick <[email protected]>
> ---
> drivers/net/wireless/rt2x00/rt2x00dev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/rt2x00/rt2x00dev.c b/drivers/net/wireless/rt2x00/rt2x00dev.c
> index 2bde672..c2c2300 100644
> --- a/drivers/net/wireless/rt2x00/rt2x00dev.c
> +++ b/drivers/net/wireless/rt2x00/rt2x00dev.c
> @@ -1452,8 +1452,7 @@ void rt2x00lib_remove_dev(struct rt2x00_dev *rt2x00dev)
> /*
> * Free the driver data.
> */
> - if (rt2x00dev->drv_data)
> - kfree(rt2x00dev->drv_data);
> + kfree(rt2x00dev->drv_data);
> }
> EXPORT_SYMBOL_GPL(rt2x00lib_remove_dev);
>
> --
> 1.8.4.5
>