2023-07-11 09:37:08

by Chen-Yu Tsai

Subject: [PATCH] drm/panel-edp: Add AUO B116XAB01.4 (HW:0A) panel entry

This panel is found at least on the MT8183-based Juniper Chromebook,
also known as the Acer Chromebook Spin 311. It matches the common
delay_200_500_e50 set of delay timings.

Add an entry for it.

Signed-off-by: Chen-Yu Tsai <[email protected]>
---
drivers/gpu/drm/panel/panel-edp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index fbd114b4f0be..df7e3cff004c 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1866,6 +1866,7 @@ static const struct panel_delay delay_200_500_e200 = {
*/
static const struct edp_panel_entry edp_panels[] = {
EDP_PANEL_ENTRY('A', 'U', 'O', 0x1062, &delay_200_500_e50, "B120XAN01.0"),
+ EDP_PANEL_ENTRY('A', 'U', 'O', 0x145c, &delay_200_500_e50, "B116XAB01.4"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0x1ea5, &delay_200_500_e50, "B116XAK01.6"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),
--
2.41.0.390.g38632f3daf-goog

2023-07-17 21:59:36

by Doug Anderson

Subject: Re: [PATCH] drm/panel-edp: Add AUO B116XAB01.4 (HW:0A) panel entry

Hi,

On Tue, Jul 11, 2023 at 2:12 AM Chen-Yu Tsai <[email protected]> wrote:
>
> This panel is found at least on the MT8183-based Juniper Chromebook,
> also known as the Acer Chromebook Spin 311. It matches the common
> delay_200_500_e50 set of delay timings.
>
> Add an entry for it.
>
> Signed-off-by: Chen-Yu Tsai <[email protected]>
> ---
> drivers/gpu/drm/panel/panel-edp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index fbd114b4f0be..df7e3cff004c 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1866,6 +1866,7 @@ static const struct panel_delay delay_200_500_e200 = {
> */
> static const struct edp_panel_entry edp_panels[] = {
> EDP_PANEL_ENTRY('A', 'U', 'O', 0x1062, &delay_200_500_e50, "B120XAN01.0"),
> + EDP_PANEL_ENTRY('A', 'U', 'O', 0x145c, &delay_200_500_e50, "B116XAB01.4"),
> EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
> EDP_PANEL_ENTRY('A', 'U', 'O', 0x1ea5, &delay_200_500_e50, "B116XAK01.6"),
> EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),

You're about 1 month too late. ;-) This landed in drm-misc-next as
commit 1ebc9f0365ef ("drm/panel-edp: Add AUO B116XAB01.4 edp panel
entry").

You can find it on drm-misc-next: https://cgit.freedesktop.org/drm/drm-misc/log/

Specifically see:
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1ebc9f0365ef

-Doug

2023-07-18 07:00:29

by Chen-Yu Tsai

Subject: Re: [PATCH] drm/panel-edp: Add AUO B116XAB01.4 (HW:0A) panel entry

On Tue, Jul 18, 2023 at 5:40 AM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Tue, Jul 11, 2023 at 2:12 AM Chen-Yu Tsai <[email protected]> wrote:
> >
> > This panel is found at least on the MT8183-based Juniper Chromebook,
> > also known as the Acer Chromebook Spin 311. It matches the common
> > delay_200_500_e50 set of delay timings.
> >
> > Add an entry for it.
> >
> > Signed-off-by: Chen-Yu Tsai <[email protected]>
> > ---
> > drivers/gpu/drm/panel/panel-edp.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> > index fbd114b4f0be..df7e3cff004c 100644
> > --- a/drivers/gpu/drm/panel/panel-edp.c
> > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > @@ -1866,6 +1866,7 @@ static const struct panel_delay delay_200_500_e200 = {
> > */
> > static const struct edp_panel_entry edp_panels[] = {
> > EDP_PANEL_ENTRY('A', 'U', 'O', 0x1062, &delay_200_500_e50, "B120XAN01.0"),
> > + EDP_PANEL_ENTRY('A', 'U', 'O', 0x145c, &delay_200_500_e50, "B116XAB01.4"),
> > EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B133UAN02.1"),
> > EDP_PANEL_ENTRY('A', 'U', 'O', 0x1ea5, &delay_200_500_e50, "B116XAK01.6"),
> > EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B116XAK01"),
>
> You're about 1 month too late. ;-) This landed in drm-misc-next as
> commit 1ebc9f0365ef ("drm/panel-edp: Add AUO B116XAB01.4 edp panel
> entry").
>
> You can find it on drm-misc-next: https://cgit.freedesktop.org/drm/drm-misc/log/
>
> Specifically see:
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1ebc9f0365ef

Argh, you're right. I vaguely remember it. I was on v6.5-rc1 when I sent
this.

ChenYu
> -Doug