2024-03-04 03:24:57

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Use bit operations consistently

On Sun, Mar 3, 2024 at 8:07 PM Andy Shevchenko
<[email protected]> wrote:
>
> Use BIT() where makes sense. This alings usage of bit operations
> in the same pieces of code. Moreover, strictly speaking by the
> letter of the C standard, left shift of 1 by 31 bits is UB (undefined
> behaviour), switching to BIT() addresses that as well.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Chen-Yu Tsai <[email protected]>