2023-01-24 10:52:13

by Alexander Potapenko

Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate()

On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko <[email protected]> wrote:
>
> When aops->write_begin() does not initialize fsdata, KMSAN may report
> an error passing the latter to aops->write_end().
>
> Fix this by unconditionally initializing fsdata.
>
> Suggested-by: Eric Biggers <[email protected]>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Alexander Potapenko <[email protected]>

Dear FS maintainers,

HFS/HFSPLUS are orphaned, can someone take this patch to their tree?
Thanks in advance!
(same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()":
https://lore.kernel.org/all/[email protected]/)

2023-01-24 21:04:10

by Andrew Morton

Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate()

On Tue, 24 Jan 2023 11:51:30 +0100 Alexander Potapenko <[email protected]> wrote:

> On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko <[email protected]> wrote:
> >
> > When aops->write_begin() does not initialize fsdata, KMSAN may report
> > an error passing the latter to aops->write_end().
> >
> > Fix this by unconditionally initializing fsdata.
> >
> > Suggested-by: Eric Biggers <[email protected]>
> > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > Signed-off-by: Alexander Potapenko <[email protected]>
>
> Dear FS maintainers,
>
> HFS/HFSPLUS are orphaned, can someone take this patch to their tree?
> Thanks in advance!
> (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()":
> https://lore.kernel.org/all/[email protected]/)

I grabbed both.

I removed the

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")

because that might provoke the backport bots to backport this fix
across eight years worth of kernels. Before KMSAN existed!

If you intended that this be backported then please let's come up with a
more precise Fixes: target and we'll add cc:stable.

2023-01-25 09:53:12

by Alexander Potapenko

Subject: Re: [PATCH 4/5] fs: hfs: initialize fsdata in hfs_file_truncate()

On Tue, Jan 24, 2023 at 10:04 PM Andrew Morton
<[email protected]> wrote:
>
> On Tue, 24 Jan 2023 11:51:30 +0100 Alexander Potapenko <[email protected]> wrote:
>
> > On Mon, Nov 21, 2022 at 12:21 PM Alexander Potapenko <[email protected]> wrote:
> > >
> > > When aops->write_begin() does not initialize fsdata, KMSAN may report
> > > an error passing the latter to aops->write_end().
> > >
> > > Fix this by unconditionally initializing fsdata.
> > >
> > > Suggested-by: Eric Biggers <[email protected]>
> > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> > > Signed-off-by: Alexander Potapenko <[email protected]>
> >
> > Dear FS maintainers,
> >
> > HFS/HFSPLUS are orphaned, can someone take this patch to their tree?
> > Thanks in advance!
> > (same for "fs: hfsplus: initialize fsdata in hfsplus_file_truncate()":
> > https://lore.kernel.org/all/[email protected]/)
>
> I grabbed both.
>
> I removed the
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>
> because that might provoke the backport bots to backport this fix
> across eight years worth of kernels. Before KMSAN existed!

Right, makes sense.