2021-10-01 15:04:44

by Chukun Pan

Subject: [PATCH] arm64: dts: allwinner: NanoPi R1S H5: use the correct compatible for the eeprom

The 'microchip,24c02' compatible does not match the at24 driver, so
replace it with 'atmel,24c02'. In addition, because the mac address
is stored on this eeprom, set it to read-only mode.

Signed-off-by: Chukun Pan <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
index 55bcdf8d1a07..4f01c17c49e0 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
@@ -142,9 +142,10 @@
status = "okay";

eeprom@51 {
- compatible = "microchip,24c02";
- reg = <0x51>;
+ compatible = "atmel,24c02";
pagesize = <16>;
+ reg = <0x51>;
+ read-only; /* This holds our MAC */
};
};

--
2.17.1

2021-10-05 17:53:17

by Chen-Yu Tsai

Subject: Re: [PATCH] arm64: dts: allwinner: NanoPi R1S H5: use the correct compatible for the eeprom

Hi,

On Fri, Oct 1, 2021 at 10:51 PM Chukun Pan <[email protected]> wrote:
>
> The 'microchip,24c02' compatible does not match the at24 driver, so
> replace it with 'atmel,24c02'. In addition, because the mac address
> is stored on this eeprom, set it to read-only mode.
>
> Signed-off-by: Chukun Pan <[email protected]>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> index 55bcdf8d1a07..4f01c17c49e0 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-nanopi-r1s-h5.dts
> @@ -142,9 +142,10 @@
> status = "okay";
>
> eeprom@51 {
> - compatible = "microchip,24c02";
> - reg = <0x51>;
> + compatible = "atmel,24c02";

You should add the atmel compatible as a fallback one, not replace the
microchip one.

Also FTR 24c02 is not the correct part number. It is 24aa025e48.


> pagesize = <16>;
> + reg = <0x51>;

Please don't move the reg property. It should follow the compatible.

> + read-only; /* This holds our MAC */

Please also add a cell representing the MAC address, and hook it up
to the GMAC. You can find an example here [1].

Regards
ChenYu

[1] https://lore.kernel.org/linux-rockchip/[email protected]/

> };
> };
>
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel