2022-06-06 05:15:00

by Catalin Marinas

Subject: Re: [PATCH v2 0/4] mm: kmemleak: store objects allocated with physical address separately and check when scan

On Fri, Jun 03, 2022 at 11:54:11AM +0800, Patrick Wang wrote:
> Patrick Wang (4):
> mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical
> address
> mm: kmemleak: add rbtree for objects allocated with physical address
> mm: kmemleak: handle address stored in object based on its type
> mm: kmemleak: kmemleak_*_phys() set address type and check PA when
> scan

This looks fine at a very quick look but I'll do a in-depth review next
week. One more thing needed is to remove the min_count argument to
kmemleak_alloc_phys() and assume it's always 0. After this series we
can't track them for leaking anyway.

Thanks for putting this together.

--
Catalin

2022-06-06 05:41:51

by patrick wang

Subject: Re: [PATCH v2 0/4] mm: kmemleak: store objects allocated with physical address separately and check when scan

On Fri, Jun 3, 2022 at 7:01 PM Catalin Marinas <[email protected]> wrote:
>
> On Fri, Jun 03, 2022 at 11:54:11AM +0800, Patrick Wang wrote:
> > Patrick Wang (4):
> > mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical
> > address
> > mm: kmemleak: add rbtree for objects allocated with physical address
> > mm: kmemleak: handle address stored in object based on its type
> > mm: kmemleak: kmemleak_*_phys() set address type and check PA when
> > scan
>
> This looks fine at a very quick look but I'll do a in-depth review next
> week. One more thing needed is to remove the min_count argument to
> kmemleak_alloc_phys() and assume it's always 0. After this series we
> can't track them for leaking anyway.

Will do in the next version.

Thanks,
Patrick