On Sat, Mar 29, 2014 at 1:51 AM, D. G. Jansen <[email protected]> wrote:
>
> This patch (processing events) works for me on Samsung 535.
Hi Dennis and others,
Thank you for testing. I have also been testing this patch for a
couple of days, and have not encountered any problems.
I have now submitted a request for testing on the kernel bugzilla
entry for the bug fixed by the earlier patch in question:
https://bugzilla.kernel.org/show_bug.cgi?id=44161#c173
The CC list has 62 users, so hopefully we will get some more testers.
The comment I posted is repeated below:
--------------
Created attachment 131151 [details]
process rather than discard events in acpi_ec_clear
Hi all,
If you have a machine that was (previously) affected by this bug,
could you please take the time to try a new patch for this issue?
A user with an older Samsung machine found that the earlier patch
introduced some issues for them, so this is a new patch designed to be
a better solution to the problem.
Currently the new patch has only been tested on 2 affected machines
(to my knowledge), so I would be very grateful if anyone else can test
this patch (especially users with Samsung series 5 or 7 machines).
You will need to use a recent kernel source like 3. (one which
includes the earlier acpi_ec_clear patch), or otherwise apply the
previous patch first:
https://github.com/torvalds/linux/commit/ad332c8a45330d170bb38b95209de449b31cd1b4.patch
Then apply the attachment ec_process_stale_events.patch
Please test to see if your lid closing / suspending / etc. still work
as intended with this patch.
This new patch also provides some debug information after every
resume/boot which will show up in dmesg something like:
[ 1192.208056] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.217844] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.218844] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.222835] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.223834] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.224833] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.227833] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.228834] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.229832] ACPI : EC: acpi_ec_clear: EC_SC 0x28
[ 1192.230828] ACPI : EC: 8 stale EC events cleared
Please report if you get any EC_SC bytes here _other than_ 0x28. I
only get 0x28 on my machine but I am very interested to know if other
affected machines produce something else.
If you test it, please also report your system's product code, e.g.:
# dmidecode -s system-product-name
900X3F
# dmidecode -s baseboard-product-name
NP900X3F-K01AU
Many thanks,
Kieran
Hello,
Thank you for the patch. Since the update from 3.13.6 to 3.13.7, I have
the same problem with the lid opening that is not detected on my Samsung
N210. This patch fixes the problem.
I think this problem may affect more Samsung netbooks with similar
hardware (N220, and maybe others).
Do you have any idea of how much time will it take to merge it to the
mainline ?
Thank you
Regards
Nicolas Porcel
On 01/04/2014 17:53, Kieran Clancy wrote:
> On Sat, Mar 29, 2014 at 1:51 AM, D. G. Jansen <[email protected]> wrote:
>> This patch (processing events) works for me on Samsung 535.
> Hi Dennis and others,
>
> Thank you for testing. I have also been testing this patch for a
> couple of days, and have not encountered any problems.
>
> I have now submitted a request for testing on the kernel bugzilla
> entry for the bug fixed by the earlier patch in question:
>
> https://bugzilla.kernel.org/show_bug.cgi?id=44161#c173
>
> The CC list has 62 users, so hopefully we will get some more testers.
> The comment I posted is repeated below:
>
> --------------
>
> Created attachment 131151 [details]
> process rather than discard events in acpi_ec_clear
>
> Hi all,
>
> If you have a machine that was (previously) affected by this bug,
> could you please take the time to try a new patch for this issue?
>
> A user with an older Samsung machine found that the earlier patch
> introduced some issues for them, so this is a new patch designed to be
> a better solution to the problem.
>
> Currently the new patch has only been tested on 2 affected machines
> (to my knowledge), so I would be very grateful if anyone else can test
> this patch (especially users with Samsung series 5 or 7 machines).
>
> You will need to use a recent kernel source like 3. (one which
> includes the earlier acpi_ec_clear patch), or otherwise apply the
> previous patch first:
>
> https://github.com/torvalds/linux/commit/ad332c8a45330d170bb38b95209de449b31cd1b4.patch
>
> Then apply the attachment ec_process_stale_events.patch
>
> Please test to see if your lid closing / suspending / etc. still work
> as intended with this patch.
>
> This new patch also provides some debug information after every
> resume/boot which will show up in dmesg something like:
>
> [ 1192.208056] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.217844] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.218844] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.222835] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.223834] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.224833] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.227833] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.228834] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.229832] ACPI : EC: acpi_ec_clear: EC_SC 0x28
> [ 1192.230828] ACPI : EC: 8 stale EC events cleared
>
> Please report if you get any EC_SC bytes here _other than_ 0x28. I
> only get 0x28 on my machine but I am very interested to know if other
> affected machines produce something else.
>
> If you test it, please also report your system's product code, e.g.:
>
> # dmidecode -s system-product-name
> 900X3F
> # dmidecode -s baseboard-product-name
> NP900X3F-K01AU
>
> Many thanks,
> Kieran
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Apr 1, 2014 at 10:06 PM, Nicolas Porcel
<[email protected]> wrote:
> Do you have any idea of how much time will it take to merge it to the
> mainline ?
Apologies for the breakage. The key here is that we want a patch which
works 100% on all Samsung systems. If we rush a fix for this
regression, we may risk breaking things on other systems.
Fortunately, the work-around in the case of this regression is very
simple (just repeat whatever event was ignored the first time, be it
lid open, ac plug, etc) compared to the bug which the original patch
fixed (which had no real workaround and caused near-permanent
malfunction).
This is why I am asking people with Samsung systems to test the patch
(with the debug output I added in the kernel bugzilla attachment) and
confirm that it is working. I am also asking them to report EC_SC data
because we may be able to create a more targeted patch with this
information.
Speaking of which, can you please let me know the EC_SC bytes you see
when you test it on your system, and if it is always the same?
Once I hear back from users on a range of Samsung systems, I will
submit a patch. It should have enough time to land before 3.15. I will
also ask for it to be included in other stable branches.
Kind regards,
Kieran
Sure, I understand that you need to test it, that's why I am asking. I
don't want an untested patch to be included in the kernel either. We
also have to make sure that the patch fix the regression for all the
affected Samsung laptops.
For the EC_SC code, I am using the first version of the patch without
the pr_info line, so I need to recompile the kernel. I'll let you know
as soon as it's done.
Best regards,
Nicolas Porcel
On 01/04/2014 19:58, Kieran Clancy wrote:
> On Tue, Apr 1, 2014 at 10:06 PM, Nicolas Porcel
> <[email protected]> wrote:
>> Do you have any idea of how much time will it take to merge it to the
>> mainline ?
> Apologies for the breakage. The key here is that we want a patch which
> works 100% on all Samsung systems. If we rush a fix for this
> regression, we may risk breaking things on other systems.
>
> Fortunately, the work-around in the case of this regression is very
> simple (just repeat whatever event was ignored the first time, be it
> lid open, ac plug, etc) compared to the bug which the original patch
> fixed (which had no real workaround and caused near-permanent
> malfunction).
>
> This is why I am asking people with Samsung systems to test the patch
> (with the debug output I added in the kernel bugzilla attachment) and
> confirm that it is working. I am also asking them to report EC_SC data
> because we may be able to create a more targeted patch with this
> information.
>
> Speaking of which, can you please let me know the EC_SC bytes you see
> when you test it on your system, and if it is always the same?
>
> Once I hear back from users on a range of Samsung systems, I will
> submit a patch. It should have enough time to land before 3.15. I will
> also ask for it to be included in other stable branches.
>
> Kind regards,
> Kieran
I managed to recompile the kernel. Here is what I see in the logs:
kernel: ACPI : EC: acpi_ec_clear: EC_SC 0x20
kernel: ACPI : EC: acpi_ec_clear: EC_SC 0x08
kernel: ACPI : EC: 1 stale EC events cleared
I hope this will help
Regards,
Nicolas Porcel
Le 01/04/2014 20:18, Nicolas Porcel a ?crit :
> Sure, I understand that you need to test it, that's why I am asking. I
> don't want an untested patch to be included in the kernel either. We
> also have to make sure that the patch fix the regression for all the
> affected Samsung laptops.
>
> For the EC_SC code, I am using the first version of the patch without
> the pr_info line, so I need to recompile the kernel. I'll let you know
> as soon as it's done.
>
> Best regards,
>
> Nicolas Porcel
>
> On 01/04/2014 19:58, Kieran Clancy wrote:
>> On Tue, Apr 1, 2014 at 10:06 PM, Nicolas Porcel
>> <[email protected]> wrote:
>>> Do you have any idea of how much time will it take to merge it to the
>>> mainline ?
>> Apologies for the breakage. The key here is that we want a patch which
>> works 100% on all Samsung systems. If we rush a fix for this
>> regression, we may risk breaking things on other systems.
>>
>> Fortunately, the work-around in the case of this regression is very
>> simple (just repeat whatever event was ignored the first time, be it
>> lid open, ac plug, etc) compared to the bug which the original patch
>> fixed (which had no real workaround and caused near-permanent
>> malfunction).
>>
>> This is why I am asking people with Samsung systems to test the patch
>> (with the debug output I added in the kernel bugzilla attachment) and
>> confirm that it is working. I am also asking them to report EC_SC data
>> because we may be able to create a more targeted patch with this
>> information.
>>
>> Speaking of which, can you please let me know the EC_SC bytes you see
>> when you test it on your system, and if it is always the same?
>>
>> Once I hear back from users on a range of Samsung systems, I will
>> submit a patch. It should have enough time to land before 3.15. I will
>> also ask for it to be included in other stable branches.
>>
>> Kind regards,
>> Kieran
>