2015-05-20 22:38:31

by Stefan Agner

[permalink] [raw]
Subject: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
platforms.

Signed-off-by: Stefan Agner <[email protected]>
---
arch/arm/configs/efm32_defconfig | 2 +-
arch/arm/configs/lpc18xx_defconfig | 1 +
arch/arm/configs/stm32_defconfig | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm/configs/efm32_defconfig b/arch/arm/configs/efm32_defconfig
index c4c17e3..c0dac0f0f 100644
--- a/arch/arm/configs/efm32_defconfig
+++ b/arch/arm/configs/efm32_defconfig
@@ -16,6 +16,7 @@ CONFIG_EMBEDDED=y
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_MMU is not set
+CONFIG_ARM_SINGLE_ARMV7M=y
CONFIG_ARCH_EFM32=y
CONFIG_SET_MEM_PARAM=y
CONFIG_DRAM_BASE=0x88000000
@@ -85,7 +86,6 @@ CONFIG_GPIO_SYSFS=y
# CONFIG_USB_SUPPORT is not set
CONFIG_MMC=y
CONFIG_MMC_SPI=y
-# CONFIG_IOMMU_SUPPORT is not set
CONFIG_EXT2_FS=y
# CONFIG_FILE_LOCKING is not set
# CONFIG_DNOTIFY is not set
diff --git a/arch/arm/configs/lpc18xx_defconfig b/arch/arm/configs/lpc18xx_defconfig
index caf7b52..d4320a7 100644
--- a/arch/arm/configs/lpc18xx_defconfig
+++ b/arch/arm/configs/lpc18xx_defconfig
@@ -22,6 +22,7 @@ CONFIG_EMBEDDED=y
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_MMU is not set
+CONFIG_ARM_SINGLE_ARMV7M=y
CONFIG_ARCH_LPC18XX=y
CONFIG_SET_MEM_PARAM=y
CONFIG_DRAM_BASE=0x28000000
diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index fab9cf9..4725fab 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -18,6 +18,7 @@ CONFIG_EMBEDDED=y
# CONFIG_IOSCHED_DEADLINE is not set
# CONFIG_IOSCHED_CFQ is not set
# CONFIG_MMU is not set
+CONFIG_ARM_SINGLE_ARMV7M=y
CONFIG_ARCH_STM32=y
CONFIG_SET_MEM_PARAM=y
CONFIG_DRAM_BASE=0x90000000
--
2.4.1


2015-05-21 08:26:11

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

Hello,

On Thu, May 21, 2015 at 12:38:21AM +0200, Stefan Agner wrote:
> Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
> platforms.
I assume this relates to your series that introduces this symbol. Should
the defconfig update happen before? (Or what is the result if
CONFIG_ARM_SINGLE_ARMV7M=y is missing in the defconfig while the symbol
already exists?) Maybe this should be squashed into the commit in
question?

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |

2015-05-21 09:29:37

by Stefan Agner

[permalink] [raw]
Subject: Re: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

On 2015-05-21 10:26, Uwe Kleine-König wrote:
> On Thu, May 21, 2015 at 12:38:21AM +0200, Stefan Agner wrote:
>> Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
>> platforms.
> I assume this relates to your series that introduces this symbol. Should
> the defconfig update happen before? (Or what is the result if
> CONFIG_ARM_SINGLE_ARMV7M=y is missing in the defconfig while the symbol
> already exists?) Maybe this should be squashed into the commit in
> question?

The Kconfig system defaults to versatile then, it tried yesterday and I
think it and it compiled fine actually. However, it is of course not
what the user wants.

The defconfigs of the new machines are currently in arm-soc
next/defconfig. While testing, I just merged the defconfig branch into
the soc branch, but then splitted the patch in two independent patches.
Arnd, what do you think?

--
Stefan

2015-05-21 17:01:35

by Joachim Eastwood

[permalink] [raw]
Subject: Re: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

Hi Stefan.

On 21 May 2015 at 00:38, Stefan Agner <[email protected]> wrote:
> Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
> platforms.
>
> Signed-off-by: Stefan Agner <[email protected]>

For the LPC18xx config;

Acked-by: Joachim Eastwood <[email protected]>

regards,
Joachim Eastwood

2015-05-22 14:56:27

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

On Thursday 21 May 2015 10:26:04 Uwe Kleine-K?nig wrote:
>
> On Thu, May 21, 2015 at 12:38:21AM +0200, Stefan Agner wrote:
> > Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
> > platforms.
> I assume this relates to your series that introduces this symbol. Should
> the defconfig update happen before? (Or what is the result if
> CONFIG_ARM_SINGLE_ARMV7M=y is missing in the defconfig while the symbol
> already exists?) Maybe this should be squashed into the commit in
> question?
>

I've folded the efm32_defconfig change into the patch that introduces
the ARM_SINGLE_ARMV7M symbol now, to avoid bisection problems.

Arnd

2015-05-22 14:59:15

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH defconfig] ARM: add ARM_SINGLE_ARMV7M in ARMv7-M defconfigs

On Thursday 21 May 2015 00:38:21 Stefan Agner wrote:
> Select ARM_SINGLE_ARMV7M in defconfigs of the converted ARMv7-M
> platforms.
>
> Signed-off-by: Stefan Agner <[email protected]>

Applied without the efm32_defconfig change, as I have moved that
into the other patch.

Thanks,

Arnd