2022-04-19 18:37:45

by Krzysztof Kozlowski

Subject: [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname()

Use devm_platform_ioremap_resource_byname() instead of
platform_get_resource_byname() and devm_ioremap_resource().

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
drivers/memory/brcmstb_dpfe.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
index 14412002775d..76c82e9c8fce 100644
--- a/drivers/memory/brcmstb_dpfe.c
+++ b/drivers/memory/brcmstb_dpfe.c
@@ -857,7 +857,6 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct brcmstb_dpfe_priv *priv;
- struct resource *res;
int ret;

priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
@@ -869,22 +868,19 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
mutex_init(&priv->lock);
platform_set_drvdata(pdev, priv);

- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-cpu");
- priv->regs = devm_ioremap_resource(dev, res);
+ priv->regs = devm_platform_ioremap_resource_byname(pdev, "dpfe-cpu");
if (IS_ERR(priv->regs)) {
dev_err(dev, "couldn't map DCPU registers\n");
return -ENODEV;
}

- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-dmem");
- priv->dmem = devm_ioremap_resource(dev, res);
+ priv->dmem = devm_platform_ioremap_resource_byname(pdev, "dpfe-dmem");
if (IS_ERR(priv->dmem)) {
dev_err(dev, "Couldn't map DCPU data memory\n");
return -ENOENT;
}

- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-imem");
- priv->imem = devm_ioremap_resource(dev, res);
+ priv->imem = devm_platform_ioremap_resource_byname(pdev, "dpfe-imem");
if (IS_ERR(priv->imem)) {
dev_err(dev, "Couldn't map DCPU instruction memory\n");
return -ENOENT;
--
2.32.0

2022-04-27 10:02:57

by Markus Mayer

Subject: Re: [PATCH 6/7] memory: brcmstb_dpfe: simplify platform_get_resource_byname()

On Tue, 19 Apr 2022 at 07:29, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Use devm_platform_ioremap_resource_byname() instead of
> platform_get_resource_byname() and devm_ioremap_resource().
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Thanks for the change.

Acked-by: Markus Mayer <[email protected]>

Regards,
-Markus

> ---
> drivers/memory/brcmstb_dpfe.c | 10 +++-------
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/memory/brcmstb_dpfe.c b/drivers/memory/brcmstb_dpfe.c
> index 14412002775d..76c82e9c8fce 100644
> --- a/drivers/memory/brcmstb_dpfe.c
> +++ b/drivers/memory/brcmstb_dpfe.c
> @@ -857,7 +857,6 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct brcmstb_dpfe_priv *priv;
> - struct resource *res;
> int ret;
>
> priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
> @@ -869,22 +868,19 @@ static int brcmstb_dpfe_probe(struct platform_device *pdev)
> mutex_init(&priv->lock);
> platform_set_drvdata(pdev, priv);
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-cpu");
> - priv->regs = devm_ioremap_resource(dev, res);
> + priv->regs = devm_platform_ioremap_resource_byname(pdev, "dpfe-cpu");
> if (IS_ERR(priv->regs)) {
> dev_err(dev, "couldn't map DCPU registers\n");
> return -ENODEV;
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-dmem");
> - priv->dmem = devm_ioremap_resource(dev, res);
> + priv->dmem = devm_platform_ioremap_resource_byname(pdev, "dpfe-dmem");
> if (IS_ERR(priv->dmem)) {
> dev_err(dev, "Couldn't map DCPU data memory\n");
> return -ENOENT;
> }
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "dpfe-imem");
> - priv->imem = devm_ioremap_resource(dev, res);
> + priv->imem = devm_platform_ioremap_resource_byname(pdev, "dpfe-imem");
> if (IS_ERR(priv->imem)) {
> dev_err(dev, "Couldn't map DCPU instruction memory\n");
> return -ENOENT;
> --
> 2.32.0
>