2021-04-01 07:53:18

by Jiabing Wan

Subject: [PATCH] fs: cifs: Remove unnecessary struct declaration

struct cifs_readdata is declared twice. One is declared
at 208th line.
And struct cifs_readdata is defined blew.
The declaration here is not needed. Remove the duplicate.

Signed-off-by: Wan Jiabing <[email protected]>
---
fs/cifs/cifsglob.h | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
index 67c056a9a519..ec824ab8c5ca 100644
--- a/fs/cifs/cifsglob.h
+++ b/fs/cifs/cifsglob.h
@@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
bool direct_io;
};

-struct cifs_readdata;
-
/* asynchronous read support */
struct cifs_readdata {
struct kref refcount;
--
2.25.1

2021-04-02 15:45:30

by Steve French

Subject: Re: [PATCH] fs: cifs: Remove unnecessary struct declaration

merged into cifs-2.6.git for-next

On Thu, Apr 1, 2021 at 2:52 AM Wan Jiabing <[email protected]> wrote:
>
> struct cifs_readdata is declared twice. One is declared
> at 208th line.
> And struct cifs_readdata is defined blew.
> The declaration here is not needed. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <[email protected]>
> ---
> fs/cifs/cifsglob.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/cifs/cifsglob.h b/fs/cifs/cifsglob.h
> index 67c056a9a519..ec824ab8c5ca 100644
> --- a/fs/cifs/cifsglob.h
> +++ b/fs/cifs/cifsglob.h
> @@ -1283,8 +1283,6 @@ struct cifs_aio_ctx {
> bool direct_io;
> };
>
> -struct cifs_readdata;
> -
> /* asynchronous read support */
> struct cifs_readdata {
> struct kref refcount;
> --
> 2.25.1
>


--
Thanks,

Steve