This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver. Also,
the private data is defined in this driver, so there is no risk of it being
accessed outside of this driver file.
Signed-off-by: Andrei Coardos <[email protected]>
---
drivers/reset/reset-ti-syscon.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
index f0dd7ffc3b72..23f86ddb8668 100644
--- a/drivers/reset/reset-ti-syscon.c
+++ b/drivers/reset/reset-ti-syscon.c
@@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
data->controls = controls;
data->nr_controls = nr_controls;
- platform_set_drvdata(pdev, data);
-
return devm_reset_controller_register(dev, &data->rcdev);
}
--
2.34.1
On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <[email protected]> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
Reviewed-by: Alexandru Ardelean <[email protected]>
// also adding the people listed as MODULE_AUTHOR
// the list seems a bit short otherwise; no idea if these emails work
> Signed-off-by: Andrei Coardos <[email protected]>
> ---
> drivers/reset/reset-ti-syscon.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
> index f0dd7ffc3b72..23f86ddb8668 100644
> --- a/drivers/reset/reset-ti-syscon.c
> +++ b/drivers/reset/reset-ti-syscon.c
> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
> data->controls = controls;
> data->nr_controls = nr_controls;
>
> - platform_set_drvdata(pdev, data);
> -
> return devm_reset_controller_register(dev, &data->rcdev);
> }
>
> --
> 2.34.1
>
On 8/7/23 6:57 AM, Alexandru Ardelean wrote:
> On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <[email protected]> wrote:
>>
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
>
> Reviewed-by: Alexandru Ardelean <[email protected]>
>
> // also adding the people listed as MODULE_AUTHOR
> // the list seems a bit short otherwise; no idea if these emails work
>
>> Signed-off-by: Andrei Coardos <[email protected]>
>> ---
LGTM,
Acked-by: Andrew Davis <[email protected]>
>> drivers/reset/reset-ti-syscon.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
>> index f0dd7ffc3b72..23f86ddb8668 100644
>> --- a/drivers/reset/reset-ti-syscon.c
>> +++ b/drivers/reset/reset-ti-syscon.c
>> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
>> data->controls = controls;
>> data->nr_controls = nr_controls;
>>
>> - platform_set_drvdata(pdev, data);
>> -
>> return devm_reset_controller_register(dev, &data->rcdev);
>> }
>>
>> --
>> 2.34.1
>>
On Mo, 2023-08-07 at 14:15 +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <[email protected]>
Thank you, applied to reset/next.
regards
Philipp