Split sparse warning fixes into multiple patches.
Joseph Wright (2):
Staging: android/ion: fix sparse warnings
Staging: android/ion: fix sparse warning
drivers/staging/android/ion/ion.h | 4 ++++
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)
--
2.9.3
Declare functions to fix sparse warnings:
ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
was not declared. Should it be static?
ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
was not declared. Should it be static?
Signed-off-by: Joseph Wright <[email protected]>
---
Changes in v2:
- Split into multiple patches
drivers/staging/android/ion/ion.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index fa9ed81..fda1e91 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -358,4 +358,8 @@ long ion_ioctl(struct file *filp, unsigned int cmd, unsigned long arg);
int ion_query_heaps(struct ion_heap_query *query);
+struct ion_heap *ion_chunk_heap_create(struct ion_platform_heap *heap_data);
+
+struct ion_heap *ion_carveout_heap_create(struct ion_platform_heap *heap_data);
+
#endif /* _ION_H */
--
2.9.3
Declare private function static to fix sparse warning:
ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
was not declared. Should it be static?
Signed-off-by: Joseph Wright <[email protected]>
---
Changes in v2:
- Split into multiple patches
drivers/staging/android/ion/ion_cma_heap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
index a0949bc..c6db9b7 100644
--- a/drivers/staging/android/ion/ion_cma_heap.c
+++ b/drivers/staging/android/ion/ion_cma_heap.c
@@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
return &cma_heap->heap;
}
-int __ion_add_cma_heaps(struct cma *cma, void *data)
+static int __ion_add_cma_heaps(struct cma *cma, void *data)
{
struct ion_heap *heap;
--
2.9.3
Hi,
please consider changing your subject to something like
staging: android/ion: declare two functions
Perhaps you can make it more on-topic. It's more useful than "fix
sparse warning"
On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright <[email protected]> wrote:
> Declare functions to fix sparse warnings:
>
> ion_carveout_heap.c:115:17: warning: symbol 'ion_carveout_heap_create' \
> was not declared. Should it be static?
> ion_chunk_heap.c:120:17: warning: symbol 'ion_chunk_heap_create' \
> was not declared. Should it be static?
And then explain why declaring them is preferred over making them static.
Frans
Hi,
Again, your subject is too generic.
On Wed, Jul 12, 2017 at 6:51 AM, Joseph Wright <[email protected]> wrote:
> Declare private function static to fix sparse warning:
>
> ion_cma_heap.c:109:5: warning: symbol '__ion_add_cma_heaps' \
> was not declared. Should it be static?
>
> Signed-off-by: Joseph Wright <[email protected]>
> ---
> Changes in v2:
> - Split into multiple patches
>
> drivers/staging/android/ion/ion_cma_heap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion_cma_heap.c b/drivers/staging/android/ion/ion_cma_heap.c
> index a0949bc..c6db9b7 100644
> --- a/drivers/staging/android/ion/ion_cma_heap.c
> +++ b/drivers/staging/android/ion/ion_cma_heap.c
> @@ -106,7 +106,7 @@ static struct ion_heap *__ion_cma_heap_create(struct cma *cma)
> return &cma_heap->heap;
> }
>
> -int __ion_add_cma_heaps(struct cma *cma, void *data)
> +static int __ion_add_cma_heaps(struct cma *cma, void *data)
> {
> struct ion_heap *heap;
>
> --
> 2.9.3
>
> _______________________________________________
> devel mailing list
> [email protected]
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel