2015-07-23 14:21:12

by Incarnation P. Lee

[permalink] [raw]
Subject: Fix one source file coding sytle issue.

drivers/staging/lustre/lustre/obdclass/cl_page.c

Signed-off-by: Incarnation P. Lee <[email protected]>


2015-07-23 14:45:31

by Frans Klaver

[permalink] [raw]
Subject: Re: Fix one source file coding sytle issue.

Hi,

On Thu, Jul 23, 2015 at 8:20 AM, Incarnation P. Lee
<[email protected]> wrote:
> drivers/staging/lustre/lustre/obdclass/cl_page.c

It is custom that you write slightly more introductory text here. Just
a file name is pointless.

The subject should probably contain [PATCH 0/5]. This would be
automatically fixed for you when using 'git format-patch
--cover-letter ...'.

The other patches should at least mention the area of the kernel the
change is done in:

[PATCH N/5] staging: lustre: fix a missing space after comma

So that it becomes immediately clear where the change is done, and
what it is supposed to achieve.


> Signed-off-by: Incarnation P. Lee <[email protected]>

That's not necessary in the cover letter.

Frans