2017-09-26 13:59:13

by Ruben Roy

Subject: [PATCH] tpm: fix duplicate inline declaration specifier

This commit fixes the duplicate inline declaration specifier in
tpm2_rc_value which caused a warning

Signed-off-by: Ruben Roy <[email protected]>
---
drivers/char/tpm/tpm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
index 04fbff2..f4d0272 100644
--- a/drivers/char/tpm/tpm.h
+++ b/drivers/char/tpm/tpm.h
@@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
}
#endif

-static inline inline u32 tpm2_rc_value(u32 rc)
+static inline u32 tpm2_rc_value(u32 rc)
{
return (rc & BIT(7)) ? rc & 0xff : rc;
}
--
1.8.3.1

2017-09-29 17:17:10

by Jarkko Sakkinen

Subject: Re: [PATCH] tpm: fix duplicate inline declaration specifier

On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
> This commit fixes the duplicate inline declaration specifier in
> tpm2_rc_value which caused a warning
>
> Signed-off-by: Ruben Roy <[email protected]>
> ---
> drivers/char/tpm/tpm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> index 04fbff2..f4d0272 100644
> --- a/drivers/char/tpm/tpm.h
> +++ b/drivers/char/tpm/tpm.h
> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
> }
> #endif
>
> -static inline inline u32 tpm2_rc_value(u32 rc)
> +static inline u32 tpm2_rc_value(u32 rc)
> {
> return (rc & BIT(7)) ? rc & 0xff : rc;
> }
> --
> 1.8.3.1
>

Reviewed-by: Jarkko Sakkinen <[email protected]>

/Jarkko

2017-09-30 00:46:45

by Nick Desaulniers

Subject: Re: [PATCH] tpm: fix duplicate inline declaration specifier

Thanks! This fixes a warning I was seeing with Clang:

drivers/char/tpm/tpm.h:560:15: warning: duplicate 'inline' declaration
specifier [-Wduplicate-decl-specifier]

On Fri, Sep 29, 2017 at 10:17 AM, Jarkko Sakkinen
<[email protected]> wrote:
> On Tue, Sep 26, 2017 at 01:58:57PM +0000, Ruben Roy wrote:
>> This commit fixes the duplicate inline declaration specifier in
>> tpm2_rc_value which caused a warning
>>
>> Signed-off-by: Ruben Roy <[email protected]>
>> ---
>> drivers/char/tpm/tpm.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
>> index 04fbff2..f4d0272 100644
>> --- a/drivers/char/tpm/tpm.h
>> +++ b/drivers/char/tpm/tpm.h
>> @@ -550,7 +550,7 @@ static inline void tpm_add_ppi(struct tpm_chip *chip)
>> }
>> #endif
>>
>> -static inline inline u32 tpm2_rc_value(u32 rc)
>> +static inline u32 tpm2_rc_value(u32 rc)
>> {
>> return (rc & BIT(7)) ? rc & 0xff : rc;
>> }
>> --
>> 1.8.3.1
>>
>
> Reviewed-by: Jarkko Sakkinen <[email protected]>
>
> /Jarkko