2023-09-15 09:11:14

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH 00/12] Add Milk-V Pioneer RISC-V board support

Hey,

On Fri, Sep 15, 2023 at 03:08:56PM +0800, Wang Chen wrote:
> Milk-V Pioneer [1] is a developer motherboard based on SOPHON SG2042 [2]
> in a standard mATX form factor. Add minimal device
> tree files for the SG2042 SOC and the Milk-V Pioneer board.

Cool, thanks for working on this.

>
> Now only support basic uart drivers to boot up into a basic console.
>
> The patch series is based on v6.6-rc1. You can simply review or test
> the patches at the link [3]. Hope this series will be merged soon.
>
> Thanks
>
> [1]: https://milkv.io/pioneer
> [2]: https://en.sophgo.com/product/introduce/sg2042.html
> [3]: https://github.com/unicornx/linux-riscv/commits/milkv-pioneer-minimal
>
> Emil Renner Berthing (2):
> dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2042 uarts
> serial: 8250_dw: Add Sophgo SG2042 support
>
> Inochi Amaoto (1):
> dt-bindings: timer: Add Sophgo sg2042 clint
>
> Wang Chen (8):
> dt-bindings: vendor-prefixes: add milkv/sophgo
> dt-bindings: riscv: add sophgo sg2042 bindings
> dt-bindings: riscv: Add T-HEAD C920 compatibles
> dt-bindings: interrupt-controller: Add SOPHGO's SG2042 PLIC
> riscv: dts: add initial SOPHGO SG2042 SoC device tree
> riscv: dts: sophgo: add Milk-V Pioneer board device tree
> riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles
> riscv: defconfig: enable SOPHGO SoC
>
> xiaoguang.xing (1):
> riscv: Add SOPHGO SOC family Kconfig support

One thing on sending patchsets - you've not threaded this patchset,
where each patch is a reply to the cover letter. This makes it more
difficult to apply the series as a human & ~impossible for the
automation to test correctly.
Git should do this for you if run send-email on an entire directory,
or you can pass the message-id of the cover letter with an argument.
The first option is likely a lot easier for you...

Thanks,
Conor.


Attachments:
(No filename) (1.88 kB)
signature.asc (235.00 B)
Download all attachments

2023-09-16 03:58:19

by Chen Wang

[permalink] [raw]
Subject: Re: [PATCH 00/12] Add Milk-V Pioneer RISC-V board support

Regards,

unicornx

Conor Dooley <[email protected]> 于2023年9月15日周五 15:26写道:
>
> Hey,
>
> On Fri, Sep 15, 2023 at 03:08:56PM +0800, Wang Chen wrote:
> > Milk-V Pioneer [1] is a developer motherboard based on SOPHON SG2042 [2]
> > in a standard mATX form factor. Add minimal device
> > tree files for the SG2042 SOC and the Milk-V Pioneer board.
>
> Cool, thanks for working on this.
>
> >
> > Now only support basic uart drivers to boot up into a basic console.
> >
> > The patch series is based on v6.6-rc1. You can simply review or test
> > the patches at the link [3]. Hope this series will be merged soon.
> >
> > Thanks
> >
> > [1]: https://milkv.io/pioneer
> > [2]: https://en.sophgo.com/product/introduce/sg2042.html
> > [3]: https://github.com/unicornx/linux-riscv/commits/milkv-pioneer-minimal
> >
> > Emil Renner Berthing (2):
> > dt-bindings: serial: snps-dw-apb-uart: Add Sophgo SG2042 uarts
> > serial: 8250_dw: Add Sophgo SG2042 support
> >
> > Inochi Amaoto (1):
> > dt-bindings: timer: Add Sophgo sg2042 clint
> >
> > Wang Chen (8):
> > dt-bindings: vendor-prefixes: add milkv/sophgo
> > dt-bindings: riscv: add sophgo sg2042 bindings
> > dt-bindings: riscv: Add T-HEAD C920 compatibles
> > dt-bindings: interrupt-controller: Add SOPHGO's SG2042 PLIC
> > riscv: dts: add initial SOPHGO SG2042 SoC device tree
> > riscv: dts: sophgo: add Milk-V Pioneer board device tree
> > riscv: dts: sophgo: Add sophgo,sg2024-uart compatibles
> > riscv: defconfig: enable SOPHGO SoC
> >
> > xiaoguang.xing (1):
> > riscv: Add SOPHGO SOC family Kconfig support
>
> One thing on sending patchsets - you've not threaded this patchset,
> where each patch is a reply to the cover letter. This makes it more
> difficult to apply the series as a human & ~impossible for the
> automation to test correctly.
> Git should do this for you if run send-email on an entire directory,
> or you can pass the message-id of the cover letter with an argument.
> The first option is likely a lot easier for you...
>
> Thanks,
> Conor.

Conor, thanks for your input, I will correct the sending of patchsets
in next revision.