LinuxLists.cc - [PATCH] staging: Change kzalloc to kcalloc

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Wed, Jul 23, 2014 at 07:03:01PM -0400, Nicholas Krause wrote:
> This changes the call to kzalloc to kcalloc in ion_dummy_driver
> for allocating the heap.
>
> Signed-off-by: Nicholas Krause <[email protected]>
> ---
> drivers/staging/android/ion/ion_dummy_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion_dummy_driver.c b/drivers/staging/android/ion/ion_dummy_driver.c
> index 3a45e79..8883432 100644
> --- a/drivers/staging/android/ion/ion_dummy_driver.c
> +++ b/drivers/staging/android/ion/ion_dummy_driver.c
> @@ -67,9 +67,8 @@ static int __init ion_dummy_init(void)
> {
> int i, err;
>
> idev = ion_device_create(NULL);
> - heaps = kzalloc(sizeof(struct ion_heap *) * dummy_ion_pdata.nr,
> - GFP_KERNEL);
> + heaps = kcalloc(*dummy_ion_pdata.nr , sizeof((struct ion_heap *) *dummy_ion_pdata.nr) , GFP_KERNEL);
> if (!heaps)
> return -ENOMEM;
>

Hi Nick,

Look, I know you are really enthusiastic, and want to help out. I get it.
But this patch is proof that you are not yet ready to work on a complex
project such as the Linux kernel. Maybe you want to try something
a bit easier. Like, say, systemd?

First of all, there was really nothing wrong with this code in the first
place. It is fine to use kzalloc. But lets just say you want to convert
it to kcalloc. The proper answer would have been:

heaps = kcalloc(dummy_ion_pdata.nr, sizeof(struct ion_heap *), GFP_KERNEL);

That's rather simple. Just look at the prototype of kcalloc():

void *kcalloc(size_t n, size_t size, gfp_t flags)

The three parameters are the number of elements, the size of each individual
element, and then finally the flags used on how to allocate that memory.
I have to say, you did get the flags part correct.

Now lets look at what you did. For the size you had:

*dummy_ion_ptr.nr

Do you have any idea of what that is? You just dereferenced the count.
That is, you didn't use the count, but you used the memory that is at
some location from address 0 + dummy_ion_ptr.nr. Now this probably wont
compile. At least not on 64 bit boxes as that nr field is only 32 bits
and a pointer would need to be 64 bits. It could possibly compile on
32 bit boxes, but it would definitely give you a warning about that.

Now lets look at the second parameter you used.

sizeof((struct ion_heap *) *dummy_ion_pdata.nr)

This one takes a bit of thinking about. I'm actually confused at what
you were even trying to do. What the compiler would try to do is to
break it up. First you again dereference the dummy_ion_pdata.nr with

*dummy_ion_pdata.nr

And then you convert the answer to that into the type "struct ion_heap *"

(struct ion_heap *) *dummy_ion_pdata.nr

Finally, you take the sizeof of that answer. As you converted the type
into "struct ion_heap *", I think it would give you the size of that
pointer, that is, if it would compile in the first place.

Congrats! that is actually what we want the second parameter to be!
Although I doubt that you meant to do it that way. No one would mean
to do it that way unless they had no idea of what they were doing.

Basically what this patch tells me is that you do not have enough basic
knowledge of the C language to be programming in the kernel. Maybe you
want to be a BIOS programmer?

My advice to you is to find another project (Gnome?) and work with them
until you have a strong concept of C coding and then, and only then,
come back to working on the kernel. Kernel development is no place for
novice programmers. Sorry, but that's true. It will only give you a
bad reputation, and nasty comments from the real kernel developers.

Cheers!

-- Steve

2014-07-24 14:51:41

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 10:47:25 -0400
Steven Rostedt <[email protected]> wrote:

> The three parameters are the number of elements, the size of each individual
> element, and then finally the flags used on how to allocate that memory.
> I have to say, you did get the flags part correct.
>
> Now lets look at what you did. For the size you had:

That should have read "For the count you had:"

Oh well, you get my point anyway.

-- Steve

>
> *dummy_ion_ptr.nr
>

2014-07-24 16:15:53

by Måns Rullgård

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Steven Rostedt <[email protected]> writes:

> On Thu, 24 Jul 2014 10:47:25 -0400
> Steven Rostedt <[email protected]> wrote:
>
>> The three parameters are the number of elements, the size of each individual
>> element, and then finally the flags used on how to allocate that memory.
>> I have to say, you did get the flags part correct.
>>
>> Now lets look at what you did. For the size you had:
>
> That should have read "For the count you had:"
>
> Oh well, you get my point anyway.

I have some doubts about the last bit.

--
M?ns Rullg?rd
[email protected]

2014-07-24 16:31:12

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård <[email protected]> wrote:
> Steven Rostedt <[email protected]> writes:
>
>> On Thu, 24 Jul 2014 10:47:25 -0400
>> Steven Rostedt <[email protected]> wrote:
>>
>>> The three parameters are the number of elements, the size of each individual
>>> element, and then finally the flags used on how to allocate that memory.
>>> I have to say, you did get the flags part correct.
>>>
>>> Now lets look at what you did. For the size you had:
>>
>> That should have read "For the count you had:"
>>
>> Oh well, you get my point anyway.
>
> I have some doubts about the last bit.
>
> --
> Måns Rullgård
> [email protected]

I am have this discussion with other kernel developers and just
because I send out
one patch as a newbie like this doesn't mean I don't known C.
Cheers Nick

2014-07-24 16:34:10

by Måns Rullgård

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Nick Krause <[email protected]> writes:

> On Thu, Jul 24, 2014 at 12:15 PM, M?ns Rullg?rd <[email protected]> wrote:
>> Steven Rostedt <[email protected]> writes:
>>
>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>> Steven Rostedt <[email protected]> wrote:
>>>
>>>> The three parameters are the number of elements, the size of each individual
>>>> element, and then finally the flags used on how to allocate that memory.
>>>> I have to say, you did get the flags part correct.
>>>>
>>>> Now lets look at what you did. For the size you had:
>>>
>>> That should have read "For the count you had:"
>>>
>>> Oh well, you get my point anyway.
>>
>> I have some doubts about the last bit.
>
> I am have this discussion with other kernel developers and just
> because I send out one patch as a newbie like this doesn't mean I
> don't known C.

Now I no longer have doubts; I know for certain that the point didn't
get across.

--
M?ns Rullg?rd
[email protected]

2014-07-24 16:35:56

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård <[email protected]> wrote:
> Nick Krause <[email protected]> writes:
>
>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård <[email protected]> wrote:
>>> Steven Rostedt <[email protected]> writes:
>>>
>>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>>> Steven Rostedt <[email protected]> wrote:
>>>>
>>>>> The three parameters are the number of elements, the size of each individual
>>>>> element, and then finally the flags used on how to allocate that memory.
>>>>> I have to say, you did get the flags part correct.
>>>>>
>>>>> Now lets look at what you did. For the size you had:
>>>>
>>>> That should have read "For the count you had:"
>>>>
>>>> Oh well, you get my point anyway.
>>>
>>> I have some doubts about the last bit.
>>
>> I am have this discussion with other kernel developers and just
>> because I send out one patch as a newbie like this doesn't mean I
>> don't known C.
>
> Now I no longer have doubts; I know for certain that the point didn't
> get across.
>
> --
> Måns Rullgård
> [email protected]

I get your point try other things but I talked to other kernel developers and
most of them seemed to get this feedback to when they started.
Nick

2014-07-24 16:48:03

by Måns Rullgård

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Nick Krause <[email protected]> writes:

> On Thu, Jul 24, 2014 at 12:34 PM, M?ns Rullg?rd <[email protected]> wrote:
>> Nick Krause <[email protected]> writes:
>>
>>> On Thu, Jul 24, 2014 at 12:15 PM, M?ns Rullg?rd <[email protected]> wrote:
>>>> Steven Rostedt <[email protected]> writes:
>>>>
>>>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>>>> Steven Rostedt <[email protected]> wrote:
>>>>>
>>>>>> The three parameters are the number of elements, the size of each individual
>>>>>> element, and then finally the flags used on how to allocate that memory.
>>>>>> I have to say, you did get the flags part correct.
>>>>>>
>>>>>> Now lets look at what you did. For the size you had:
>>>>>
>>>>> That should have read "For the count you had:"
>>>>>
>>>>> Oh well, you get my point anyway.
>>>>
>>>> I have some doubts about the last bit.
>>>
>>> I am have this discussion with other kernel developers and just
>>> because I send out one patch as a newbie like this doesn't mean I
>>> don't known C.
>>
>> Now I no longer have doubts; I know for certain that the point didn't
>> get across.
>
> I get your point try other things but I talked to other kernel
> developers and most of them seemed to get this feedback to when they
> started.

Most kernel devs most certainly did NOT get started by spamming lkml
with unnecessary and incorrect patches despite being repeatedly told to
go away and stop wasting everybody's time.

--
M?ns Rullg?rd
[email protected]

2014-07-24 16:50:33

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 12:47 PM, Måns Rullgård <[email protected]> wrote:
> Nick Krause <[email protected]> writes:
>
>> On Thu, Jul 24, 2014 at 12:34 PM, Måns Rullgård <[email protected]> wrote:
>>> Nick Krause <[email protected]> writes:
>>>
>>>> On Thu, Jul 24, 2014 at 12:15 PM, Måns Rullgård <[email protected]> wrote:
>>>>> Steven Rostedt <[email protected]> writes:
>>>>>
>>>>>> On Thu, 24 Jul 2014 10:47:25 -0400
>>>>>> Steven Rostedt <[email protected]> wrote:
>>>>>>
>>>>>>> The three parameters are the number of elements, the size of each individual
>>>>>>> element, and then finally the flags used on how to allocate that memory.
>>>>>>> I have to say, you did get the flags part correct.
>>>>>>>
>>>>>>> Now lets look at what you did. For the size you had:
>>>>>>
>>>>>> That should have read "For the count you had:"
>>>>>>
>>>>>> Oh well, you get my point anyway.
>>>>>
>>>>> I have some doubts about the last bit.
>>>>
>>>> I am have this discussion with other kernel developers and just
>>>> because I send out one patch as a newbie like this doesn't mean I
>>>> don't known C.
>>>
>>> Now I no longer have doubts; I know for certain that the point didn't
>>> get across.
>>
>> I get your point try other things but I talked to other kernel
>> developers and most of them seemed to get this feedback to when they
>> started.
>
> Most kernel devs most certainly did NOT get started by spamming lkml
> with unnecessary and incorrect patches despite being repeatedly told to
> go away and stop wasting everybody's time.
>
> --
> Måns Rullgård
> [email protected]

FIne , I give up. You want me to leave this then I wiil.
Nick

2014-07-24 17:18:25

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 12:50:31 -0400
Nick Krause <[email protected]> wrote:

\
> > Most kernel devs most certainly did NOT get started by spamming lkml
> > with unnecessary and incorrect patches despite being repeatedly told to
> > go away and stop wasting everybody's time.

Mans, shut up! That is uncalled for.

> >
> > --
> > M?ns Rullg?rd
> > [email protected]
>
>
>
> FIne , I give up. You want me to leave this then I wiil.

No, that's not what I said.

> I am have this discussion with other kernel developers and just
> because I send out one patch as a newbie like this doesn't mean I
> don't known C.

It's not just one patch, and I didn't say you don't know C. I said you
don't understand C enough for kernel development.

Look, I really do like you enthusiasm, and I'm sorry that you are being
attacked the way you were. Some of the attacks are uncalled for, and I
even regret some of my own previous emails to you, as they too were
uncalled for. But I do not regret my reply in this thread.

I worked in various jobs for 6 years before touching the kernel. It was
2 years after that that I started doing trivial patches (fixing
off-by-one bugs and such). Then I started out doing real time
development outside of the mainline kernel for several more years
before I starting writing code for mainline.

That is, you don't just jump into kernel development before having a
solid foundation of programming skills.

The patch I replied to didn't just have a mistake. It really was wrong
on several levels that it couldn't be right. Getting such a simple patch
so wrong really shows that you need more experience.

Please, start working with some userspace projects first, where you can
easily walk through the code using gdb to understand how things work.
Spend a year or two doing that kind of work. There's even paying jobs
out there that require this. There's tons of opensource projects that
need help. The Linux kernel is really the biggest opensource project
and very intense. A "newbie" here means you haven't done much with the
kernel, but you have done a lot of coding in the past. It doesn't mean
"newbie" to development in general.

I've been told by my wife that I'm very blunt and say what's on my
mind. I'm not very tactful, as I hate beating around the bush. I hate
it when people beat around the bush with me, I usually just tell them to
"spit it out!" Thus, I treat people as I want to be treated, that is
"in-your-face truth".

Again, don't "go away" and never come back. "go away, learn a bit more,
then come back".

A lot of us are overworked and staring at code all day. We get grumpy,
and when someone comes along and starts spamming us with nonsense
changes, we sometimes bite back. Don't take it personally. I'm serious
when I say, just spend some time on userspace projects, then work you
way to some drivers, and then you can be more active, and more
importantly, more useful to the Linux kernel project :-)

-- Steve

2014-07-24 17:30:52

by Harvey Harrison

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt <[email protected]> wrote:
> On Thu, 24 Jul 2014 12:50:31 -0400
> Nick Krause <[email protected]> wrote:

>
>> I am have this discussion with other kernel developers and just
>> because I send out one patch as a newbie like this doesn't mean I
>> don't known C.
>
> It's not just one patch, and I didn't say you don't know C. I said you
> don't understand C enough for kernel development.

And more importantly, stop guessing things are OK and selfishly asking
others to check
your work for you.

If you have not at least _built_ the kernel with your change, and not
_run_ it, and not made
sure that the changed code is being _run_...you are wasting other people's time.

Harvey

2014-07-24 17:48:55

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 10:30:51 -0700
Harvey Harrison <[email protected]> wrote:

> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt <[email protected]> wrote:
> > On Thu, 24 Jul 2014 12:50:31 -0400
> > Nick Krause <[email protected]> wrote:
>
> >
> >> I am have this discussion with other kernel developers and just
> >> because I send out one patch as a newbie like this doesn't mean I
> >> don't known C.
> >
> > It's not just one patch, and I didn't say you don't know C. I said you
> > don't understand C enough for kernel development.
>
> And more importantly, stop guessing things are OK and selfishly asking
> others to check
> your work for you.
>
> If you have not at least _built_ the kernel with your change, and not
> _run_ it, and not made
> sure that the changed code is being _run_...you are wasting other people's time.
>

Nick,

Just to bring Harvey's email here in perspective. I mentioned in my
previous email that most of us are overworked. We don't have time to
teach you if your patches are correct or not. By saying, "I'll just
write the code and you tell me if it's correct, and test it for me" is
like telling someone "Here's a lawn mower, now go mow my lawn".

We like it if people put effort into their work and are confident
themselves that they have the right code or not. There's enough
reviewing of patches to do from people that put that effort in, that
there's no time to review patches from people that don't know if their
work or not.

Cheers,

-- Steve

2014-07-24 18:41:56

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt <[email protected]> wrote:
> On Thu, 24 Jul 2014 10:30:51 -0700
> Harvey Harrison <[email protected]> wrote:
>
>> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt <[email protected]> wrote:
>> > On Thu, 24 Jul 2014 12:50:31 -0400
>> > Nick Krause <[email protected]> wrote:
>>
>> >
>> >> I am have this discussion with other kernel developers and just
>> >> because I send out one patch as a newbie like this doesn't mean I
>> >> don't known C.
>> >
>> > It's not just one patch, and I didn't say you don't know C. I said you
>> > don't understand C enough for kernel development.
>>
>> And more importantly, stop guessing things are OK and selfishly asking
>> others to check
>> your work for you.
>>
>> If you have not at least _built_ the kernel with your change, and not
>> _run_ it, and not made
>> sure that the changed code is being _run_...you are wasting other people's time.
>>
>
> Nick,
>
> Just to bring Harvey's email here in perspective. I mentioned in my
> previous email that most of us are overworked. We don't have time to
> teach you if your patches are correct or not. By saying, "I'll just
> write the code and you tell me if it's correct, and test it for me" is
> like telling someone "Here's a lawn mower, now go mow my lawn".
>
> We like it if people put effort into their work and are confident
> themselves that they have the right code or not. There's enough
> reviewing of patches to do from people that put that effort in, that
> there's no time to review patches from people that don't know if their
> work or not.
>
> Cheers,
>
> -- Steve

Steve,
I have programming a lot in other areas just not the kernel.
You are right through I need to test my code better through.
Cheers Nick

2014-07-24 18:49:23

by Richard Weinberger

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause <[email protected]> wrote:
> Steve,
> I have programming a lot in other areas just not the kernel.
> You are right through I need to test my code better through.

Nick,

let's make a deal.
Take the challenge at http://eudyptula-challenge.org. After you've solved all
tasks we'll accept patches from you.

--
Thanks,
//richard

2014-07-24 18:55:43

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
<[email protected]> wrote:
> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause <[email protected]> wrote:
>> Steve,
>> I have programming a lot in other areas just not the kernel.
>> You are right through I need to test my code better through.
>
> Nick,
>
> let's make a deal.
> Take the challenge at http://eudyptula-challenge.org. After you've solved all
> tasks we'll accept patches from you.
>
> --
> Thanks,
> //richard
That's fine,
So Sorry :(.
Nick

2014-07-24 19:05:55

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause <[email protected]> wrote:
> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
> <[email protected]> wrote:
>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause <[email protected]> wrote:
>>> Steve,
>>> I have programming a lot in other areas just not the kernel.
>>> You are right through I need to test my code better through.
>>
>> Nick,
>>
>> let's make a deal.
>> Take the challenge at http://eudyptula-challenge.org. After you've solved all
>> tasks we'll accept patches from you.
>>
>> --
>> Thanks,
>> //richard
> That's fine,
> So Sorry :(.
> Nick
I sent the challenge a email. Seems that there not replying.
Nick

2014-07-24 19:11:49

by Richard Weinberger

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Am 24.07.2014 21:05, schrieb Nick Krause:
> On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause <[email protected]> wrote:
>> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
>> <[email protected]> wrote:
>>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause <[email protected]> wrote:
>>>> Steve,
>>>> I have programming a lot in other areas just not the kernel.
>>>> You are right through I need to test my code better through.
>>>
>>> Nick,
>>>
>>> let's make a deal.
>>> Take the challenge at http://eudyptula-challenge.org. After you've solved all
>>> tasks we'll accept patches from you.
>>>
>>> --
>>> Thanks,
>>> //richard
>> That's fine,
>> So Sorry :(.
>> Nick
> I sent the challenge a email. Seems that there not replying.

Patience is a virtue.

Thanks,
//richard

2014-07-25 02:16:11

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

Excuse me, I did not see the patch details, but I guess it is about
whether welcome a new member to upstream kernel. For me, I have 3 ideas
about it if I am a newbie or a normal kernel developer:

- Do I have enough basic skills for it?

- Do I developed one or more another real world projects with C?
(they are successful projects -- at least, not failure projects)

- Can I construct related develop environments to support what I do?
(e.g. building and testing for upstream kernel)

- Am I familiar the basic working flow about kernel mailing list.
(e.g. format-patch, sending patch, email client configuration...).

- Do I have a correct attitude on it?

- Am I careful enough?
(e.g. if find some details may doubt, try to check and clear them)
(it is always neccessary for all patches)

- Am I try my best for it?
(e.g. when finish coding, try what I can do: build, run and test).
(it is neccessary for most cases)

- Do I have negative effect with others?
(e.g. discourage the newbies, or send spam to other members ...).
(need always try to avoid)

- Do I really love programming, also love open source kernel?

- Do I love it, or I have to do it for another reason?
(I guess, most of gmail members in open source, love programming).

- Do I still love programming if I am discouraged by any members?

- Do I still love open source kernel if discouraged by any members?

Thanks.

On 07/25/2014 03:11 AM, Richard Weinberger wrote:
> Am 24.07.2014 21:05, schrieb Nick Krause:
>> On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause <[email protected]> wrote:
>>> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger
>>> <[email protected]> wrote:
>>>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause <[email protected]> wrote:
>>>>> Steve,
>>>>> I have programming a lot in other areas just not the kernel.
>>>>> You are right through I need to test my code better through.
>>>>
>>>> Nick,
>>>>
>>>> let's make a deal.
>>>> Take the challenge at http://eudyptula-challenge.org. After you've solved all
>>>> tasks we'll accept patches from you.
>>>>
>>>> --
>>>> Thanks,
>>>> //richard
>>> That's fine,
>>> So Sorry :(.
>>> Nick
>> I sent the challenge a email. Seems that there not replying.
>
> Patience is a virtue.
>
> Thanks,
> //richard
>

--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-25 02:20:22

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>
> Excuse me, I did not see the patch details, but I guess it is about
> whether welcome a new member to upstream kernel. For me, I have 3 ideas
> about it if I am a newbie or a normal kernel developer:
>
> - Do I have enough basic skills for it?
>
> - Do I developed one or more another real world projects with C?
> (they are successful projects -- at least, not failure projects)
>
> - Can I construct related develop environments to support what I do?
> (e.g. building and testing for upstream kernel)
>
> - Am I familiar the basic working flow about kernel mailing list.
> (e.g. format-patch, sending patch, email client configuration...).
>
> - Do I have a correct attitude on it?
>
> - Am I careful enough?
> (e.g. if find some details may doubt, try to check and clear them)
> (it is always neccessary for all patches)
>
> - Am I try my best for it?
> (e.g. when finish coding, try what I can do: build, run and test).
> (it is neccessary for most cases)
>
> - Do I have negative effect with others?
> (e.g. discourage the newbies, or send spam to other members ...).
> (need always try to avoid)
>
> - Do I really love programming, also love open source kernel?
>
> - Do I love it, or I have to do it for another reason?
> (I guess, most of gmail members in open source, love programming).
>
> - Do I still love programming if I am discouraged by any members?
>
> - Do I still love open source kernel if discouraged by any members?
>
>
I have most of these skills other then developing real projects in C with other
developers as other then the kernel I don't have must interest in C outside
of embedded programming.
Cheers Nick

2014-07-25 02:47:12

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 10:20 AM, Nick Krause wrote:
> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>
>> Excuse me, I did not see the patch details, but I guess it is about
>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>> about it if I am a newbie or a normal kernel developer:
>>
>> - Do I have enough basic skills for it?
>>
>> - Do I developed one or more another real world projects with C?
>> (they are successful projects -- at least, not failure projects)
>>
>> - Can I construct related develop environments to support what I do?
>> (e.g. building and testing for upstream kernel)
>>
>> - Am I familiar the basic working flow about kernel mailing list.
>> (e.g. format-patch, sending patch, email client configuration...).
>>
>> - Do I have a correct attitude on it?
>>
>> - Am I careful enough?
>> (e.g. if find some details may doubt, try to check and clear them)
>> (it is always neccessary for all patches)
>>
>> - Am I try my best for it?
>> (e.g. when finish coding, try what I can do: build, run and test).
>> (it is neccessary for most cases)
>>
>> - Do I have negative effect with others?
>> (e.g. discourage the newbies, or send spam to other members ...).
>> (need always try to avoid)
>>
>> - Do I really love programming, also love open source kernel?
>>
>> - Do I love it, or I have to do it for another reason?
>> (I guess, most of gmail members in open source, love programming).
>>
>> - Do I still love programming if I am discouraged by any members?
>>
>> - Do I still love open source kernel if discouraged by any members?
>>
>>
> I have most of these skills other then developing real projects in C with other
> developers as other then the kernel I don't have must interest in C outside
> of embedded programming.

OK, thanks. If what you said is true, for me, if you will, please still
continue for open source kernel, but really need be more careful about
the patch you made before send to open mailing list.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-25 02:53:25

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>
>
> On 07/25/2014 10:20 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>
>>> Excuse me, I did not see the patch details, but I guess it is about
>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>> about it if I am a newbie or a normal kernel developer:
>>>
>>> - Do I have enough basic skills for it?
>>>
>>> - Do I developed one or more another real world projects with C?
>>> (they are successful projects -- at least, not failure projects)
>>>
>>> - Can I construct related develop environments to support what I do?
>>> (e.g. building and testing for upstream kernel)
>>>
>>> - Am I familiar the basic working flow about kernel mailing list.
>>> (e.g. format-patch, sending patch, email client configuration...).
>>>
>>> - Do I have a correct attitude on it?
>>>
>>> - Am I careful enough?
>>> (e.g. if find some details may doubt, try to check and clear them)
>>> (it is always neccessary for all patches)
>>>
>>> - Am I try my best for it?
>>> (e.g. when finish coding, try what I can do: build, run and test).
>>> (it is neccessary for most cases)
>>>
>>> - Do I have negative effect with others?
>>> (e.g. discourage the newbies, or send spam to other members ...).
>>> (need always try to avoid)
>>>
>>> - Do I really love programming, also love open source kernel?
>>>
>>> - Do I love it, or I have to do it for another reason?
>>> (I guess, most of gmail members in open source, love programming).
>>>
>>> - Do I still love programming if I am discouraged by any members?
>>>
>>> - Do I still love open source kernel if discouraged by any members?
>>>
>>>
>> I have most of these skills other then developing real projects in C with other
>> developers as other then the kernel I don't have must interest in C outside
>> of embedded programming.
>
> OK, thanks. If what you said is true, for me, if you will, please still
> continue for open source kernel, but really need be more careful about
> the patch you made before send to open mailing list.
>
>
> Thanks.
> --
> Chen Gang
>
> Open, share, and attitude like air, water, and life which God blessed

Chen ,
Thanks for helping me out here :). The true through is I don't known how to
build test correctly as a newb and thought it was better just to avoid it(stupid
me). I would like to known how to do this and if there is any way I can help you
guys out , please let me known :). I don't want to be avoided I am honestly here
to help make your life easier.
NIck

2014-07-25 03:09:47

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 10:53 AM, Nick Krause wrote:
> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>
>>
>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>
>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>> about it if I am a newbie or a normal kernel developer:
>>>>
>>>> - Do I have enough basic skills for it?
>>>>
>>>> - Do I developed one or more another real world projects with C?
>>>> (they are successful projects -- at least, not failure projects)
>>>>
>>>> - Can I construct related develop environments to support what I do?
>>>> (e.g. building and testing for upstream kernel)
>>>>
>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>
>>>> - Do I have a correct attitude on it?
>>>>
>>>> - Am I careful enough?
>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>> (it is always neccessary for all patches)
>>>>
>>>> - Am I try my best for it?
>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>> (it is neccessary for most cases)
>>>>
>>>> - Do I have negative effect with others?
>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>> (need always try to avoid)
>>>>
>>>> - Do I really love programming, also love open source kernel?
>>>>
>>>> - Do I love it, or I have to do it for another reason?
>>>> (I guess, most of gmail members in open source, love programming).
>>>>
>>>> - Do I still love programming if I am discouraged by any members?
>>>>
>>>> - Do I still love open source kernel if discouraged by any members?
>>>>
>>>>
>>> I have most of these skills other then developing real projects in C with other
>>> developers as other then the kernel I don't have must interest in C outside
>>> of embedded programming.
>>
>> OK, thanks. If what you said is true, for me, if you will, please still
>> continue for open source kernel, but really need be more careful about
>> the patch you made before send to open mailing list.
>>
>>
>> Thanks.
>> --
>> Chen Gang
>>
>> Open, share, and attitude like air, water, and life which God blessed
>
> Chen ,
> Thanks for helping me out here :). The true through is I don't known how to
> build test correctly as a newb and thought it was better just to avoid it(stupid
> me). I would like to known how to do this and if there is any way I can help you
> guys out , please let me known :). I don't want to be avoided I am honestly here
> to help make your life easier.

Excuse me, my English is not quite well, I do not understand what you
said, I guess your meaning is "not familiar with how to build and test
upstream kernel" If what I guess is incorrect, please let me know.

There are some books or some related web links for building and test
kernel, they are not quite difficult to get (please google search).

I guess, it is necessary to reference these information and construct
related develop environments to support what you want to do next.

By the way, excuse me, today I have to do some other things firstly, so
maybe my next email reply will be late (may tomorrow, or the day after
tomorrow).

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-25 03:13:15

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang <[email protected]> wrote:
>
>
> On 07/25/2014 10:53 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>>
>>>
>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>>
>>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>>> about it if I am a newbie or a normal kernel developer:
>>>>>
>>>>> - Do I have enough basic skills for it?
>>>>>
>>>>> - Do I developed one or more another real world projects with C?
>>>>> (they are successful projects -- at least, not failure projects)
>>>>>
>>>>> - Can I construct related develop environments to support what I do?
>>>>> (e.g. building and testing for upstream kernel)
>>>>>
>>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>>
>>>>> - Do I have a correct attitude on it?
>>>>>
>>>>> - Am I careful enough?
>>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>>> (it is always neccessary for all patches)
>>>>>
>>>>> - Am I try my best for it?
>>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>>> (it is neccessary for most cases)
>>>>>
>>>>> - Do I have negative effect with others?
>>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>>> (need always try to avoid)
>>>>>
>>>>> - Do I really love programming, also love open source kernel?
>>>>>
>>>>> - Do I love it, or I have to do it for another reason?
>>>>> (I guess, most of gmail members in open source, love programming).
>>>>>
>>>>> - Do I still love programming if I am discouraged by any members?
>>>>>
>>>>> - Do I still love open source kernel if discouraged by any members?
>>>>>
>>>>>
>>>> I have most of these skills other then developing real projects in C with other
>>>> developers as other then the kernel I don't have must interest in C outside
>>>> of embedded programming.
>>>
>>> OK, thanks. If what you said is true, for me, if you will, please still
>>> continue for open source kernel, but really need be more careful about
>>> the patch you made before send to open mailing list.
>>>
>>>
>>> Thanks.
>>> --
>>> Chen Gang
>>>
>>> Open, share, and attitude like air, water, and life which God blessed
>>
>> Chen ,
>> Thanks for helping me out here :). The true through is I don't known how to
>> build test correctly as a newb and thought it was better just to avoid it(stupid
>> me). I would like to known how to do this and if there is any way I can help you
>> guys out , please let me known :). I don't want to be avoided I am honestly here
>> to help make your life easier.
>
> Excuse me, my English is not quite well, I do not understand what you
> said, I guess your meaning is "not familiar with how to build and test
> upstream kernel" If what I guess is incorrect, please let me know.
>
> There are some books or some related web links for building and test
> kernel, they are not quite difficult to get (please google search).
>
> I guess, it is necessary to reference these information and construct
> related develop environments to support what you want to do next.
>
>
> By the way, excuse me, today I have to do some other things firstly, so
> maybe my next email reply will be late (may tomorrow, or the day after
> tomorrow).
>
>
> Thanks.
> --
> Chen Gang
>
> Open, share, and attitude like air, water, and life which God blessed

That's what I meant. If you can sent me a link to how to do build testing
that would be great :).
Nick

2014-07-25 03:21:58

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 11:13 AM, Nick Krause wrote:
> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang <[email protected]> wrote:
>>
>>
>> On 07/25/2014 10:53 AM, Nick Krause wrote:
>>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>>>
>>>>
>>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>>>
>>>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>>>> about it if I am a newbie or a normal kernel developer:
>>>>>>
>>>>>> - Do I have enough basic skills for it?
>>>>>>
>>>>>> - Do I developed one or more another real world projects with C?
>>>>>> (they are successful projects -- at least, not failure projects)
>>>>>>
>>>>>> - Can I construct related develop environments to support what I do?
>>>>>> (e.g. building and testing for upstream kernel)
>>>>>>
>>>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>>>
>>>>>> - Do I have a correct attitude on it?
>>>>>>
>>>>>> - Am I careful enough?
>>>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>>>> (it is always neccessary for all patches)
>>>>>>
>>>>>> - Am I try my best for it?
>>>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>>>> (it is neccessary for most cases)
>>>>>>
>>>>>> - Do I have negative effect with others?
>>>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>>>> (need always try to avoid)
>>>>>>
>>>>>> - Do I really love programming, also love open source kernel?
>>>>>>
>>>>>> - Do I love it, or I have to do it for another reason?
>>>>>> (I guess, most of gmail members in open source, love programming).
>>>>>>
>>>>>> - Do I still love programming if I am discouraged by any members?
>>>>>>
>>>>>> - Do I still love open source kernel if discouraged by any members?
>>>>>>
>>>>>>
>>>>> I have most of these skills other then developing real projects in C with other
>>>>> developers as other then the kernel I don't have must interest in C outside
>>>>> of embedded programming.
>>>>
>>>> OK, thanks. If what you said is true, for me, if you will, please still
>>>> continue for open source kernel, but really need be more careful about
>>>> the patch you made before send to open mailing list.
>>>>
>>>>
>>>> Thanks.
>>>> --
>>>> Chen Gang
>>>>
>>>> Open, share, and attitude like air, water, and life which God blessed
>>>
>>> Chen ,
>>> Thanks for helping me out here :). The true through is I don't known how to
>>> build test correctly as a newb and thought it was better just to avoid it(stupid
>>> me). I would like to known how to do this and if there is any way I can help you
>>> guys out , please let me known :). I don't want to be avoided I am honestly here
>>> to help make your life easier.
>>
>> Excuse me, my English is not quite well, I do not understand what you
>> said, I guess your meaning is "not familiar with how to build and test
>> upstream kernel" If what I guess is incorrect, please let me know.
>>
>> There are some books or some related web links for building and test
>> kernel, they are not quite difficult to get (please google search).
>>
>> I guess, it is necessary to reference these information and construct
>> related develop environments to support what you want to do next.
>>
>>
>> By the way, excuse me, today I have to do some other things firstly, so
>> maybe my next email reply will be late (may tomorrow, or the day after
>> tomorrow).
>>
>>
>> Thanks.
>> --
>> Chen Gang
>>
>> Open, share, and attitude like air, water, and life which God blessed
>
> That's what I meant. If you can sent me a link to how to do build testing
> that would be great :).

Please read README at the root directory of kernel source, also
"./Documents" contents many valuable information. And try google search
for additional information.

Try to accomplish them by yourself, that will let yourself improved with
efficiency.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-25 03:30:59

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang <[email protected]> wrote:
>
>
> On 07/25/2014 11:13 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang <[email protected]> wrote:
>>>
>>>
>>> On 07/25/2014 10:53 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>>>>
>>>>>
>>>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>>>>
>>>>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>>>>> about it if I am a newbie or a normal kernel developer:
>>>>>>>
>>>>>>> - Do I have enough basic skills for it?
>>>>>>>
>>>>>>> - Do I developed one or more another real world projects with C?
>>>>>>> (they are successful projects -- at least, not failure projects)
>>>>>>>
>>>>>>> - Can I construct related develop environments to support what I do?
>>>>>>> (e.g. building and testing for upstream kernel)
>>>>>>>
>>>>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>>>>
>>>>>>> - Do I have a correct attitude on it?
>>>>>>>
>>>>>>> - Am I careful enough?
>>>>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>>>>> (it is always neccessary for all patches)
>>>>>>>
>>>>>>> - Am I try my best for it?
>>>>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>>>>> (it is neccessary for most cases)
>>>>>>>
>>>>>>> - Do I have negative effect with others?
>>>>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>>>>> (need always try to avoid)
>>>>>>>
>>>>>>> - Do I really love programming, also love open source kernel?
>>>>>>>
>>>>>>> - Do I love it, or I have to do it for another reason?
>>>>>>> (I guess, most of gmail members in open source, love programming).
>>>>>>>
>>>>>>> - Do I still love programming if I am discouraged by any members?
>>>>>>>
>>>>>>> - Do I still love open source kernel if discouraged by any members?
>>>>>>>
>>>>>>>
>>>>>> I have most of these skills other then developing real projects in C with other
>>>>>> developers as other then the kernel I don't have must interest in C outside
>>>>>> of embedded programming.
>>>>>
>>>>> OK, thanks. If what you said is true, for me, if you will, please still
>>>>> continue for open source kernel, but really need be more careful about
>>>>> the patch you made before send to open mailing list.
>>>>>
>>>>>
>>>>> Thanks.
>>>>> --
>>>>> Chen Gang
>>>>>
>>>>> Open, share, and attitude like air, water, and life which God blessed
>>>>
>>>> Chen ,
>>>> Thanks for helping me out here :). The true through is I don't known how to
>>>> build test correctly as a newb and thought it was better just to avoid it(stupid
>>>> me). I would like to known how to do this and if there is any way I can help you
>>>> guys out , please let me known :). I don't want to be avoided I am honestly here
>>>> to help make your life easier.
>>>
>>> Excuse me, my English is not quite well, I do not understand what you
>>> said, I guess your meaning is "not familiar with how to build and test
>>> upstream kernel" If what I guess is incorrect, please let me know.
>>>
>>> There are some books or some related web links for building and test
>>> kernel, they are not quite difficult to get (please google search).
>>>
>>> I guess, it is necessary to reference these information and construct
>>> related develop environments to support what you want to do next.
>>>
>>>
>>> By the way, excuse me, today I have to do some other things firstly, so
>>> maybe my next email reply will be late (may tomorrow, or the day after
>>> tomorrow).
>>>
>>>
>>> Thanks.
>>> --
>>> Chen Gang
>>>
>>> Open, share, and attitude like air, water, and life which God blessed
>>
>> That's what I meant. If you can sent me a link to how to do build testing
>> that would be great :).
>
> Please read README at the root directory of kernel source, also
> "./Documents" contents many valuable information. And try google search
> for additional information.
>
> Try to accomplish them by yourself, that will let yourself improved with
> efficiency.
>
> Thanks.
> --
> Chen Gang
>
> Open, share, and attitude like air, water, and life which God blessed

That seems to be the issue with my programming here.
Nick

2014-07-25 03:34:50

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 11:30 AM, Nick Krause wrote:
> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang <[email protected]> wrote:
>>
>>
>> On 07/25/2014 11:13 AM, Nick Krause wrote:
>>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang <[email protected]> wrote:
>>>>
>>>>
>>>> On 07/25/2014 10:53 AM, Nick Krause wrote:
>>>>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>>>>>
>>>>>>
>>>>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>>>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>>>>>
>>>>>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>>>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>>>>>> about it if I am a newbie or a normal kernel developer:
>>>>>>>>
>>>>>>>> - Do I have enough basic skills for it?
>>>>>>>>
>>>>>>>> - Do I developed one or more another real world projects with C?
>>>>>>>> (they are successful projects -- at least, not failure projects)
>>>>>>>>
>>>>>>>> - Can I construct related develop environments to support what I do?
>>>>>>>> (e.g. building and testing for upstream kernel)
>>>>>>>>
>>>>>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>>>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>>>>>
>>>>>>>> - Do I have a correct attitude on it?
>>>>>>>>
>>>>>>>> - Am I careful enough?
>>>>>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>>>>>> (it is always neccessary for all patches)
>>>>>>>>
>>>>>>>> - Am I try my best for it?
>>>>>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>>>>>> (it is neccessary for most cases)
>>>>>>>>
>>>>>>>> - Do I have negative effect with others?
>>>>>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>>>>>> (need always try to avoid)
>>>>>>>>
>>>>>>>> - Do I really love programming, also love open source kernel?
>>>>>>>>
>>>>>>>> - Do I love it, or I have to do it for another reason?
>>>>>>>> (I guess, most of gmail members in open source, love programming).
>>>>>>>>
>>>>>>>> - Do I still love programming if I am discouraged by any members?
>>>>>>>>
>>>>>>>> - Do I still love open source kernel if discouraged by any members?
>>>>>>>>
>>>>>>>>
>>>>>>> I have most of these skills other then developing real projects in C with other
>>>>>>> developers as other then the kernel I don't have must interest in C outside
>>>>>>> of embedded programming.
>>>>>>
>>>>>> OK, thanks. If what you said is true, for me, if you will, please still
>>>>>> continue for open source kernel, but really need be more careful about
>>>>>> the patch you made before send to open mailing list.
>>>>>>
>>>>>>
>>>>>> Thanks.
>>>>>> --
>>>>>> Chen Gang
>>>>>>
>>>>>> Open, share, and attitude like air, water, and life which God blessed
>>>>>
>>>>> Chen ,
>>>>> Thanks for helping me out here :). The true through is I don't known how to
>>>>> build test correctly as a newb and thought it was better just to avoid it(stupid
>>>>> me). I would like to known how to do this and if there is any way I can help you
>>>>> guys out , please let me known :). I don't want to be avoided I am honestly here
>>>>> to help make your life easier.
>>>>
>>>> Excuse me, my English is not quite well, I do not understand what you
>>>> said, I guess your meaning is "not familiar with how to build and test
>>>> upstream kernel" If what I guess is incorrect, please let me know.
>>>>
>>>> There are some books or some related web links for building and test
>>>> kernel, they are not quite difficult to get (please google search).
>>>>
>>>> I guess, it is necessary to reference these information and construct
>>>> related develop environments to support what you want to do next.
>>>>
>>>>
>>>> By the way, excuse me, today I have to do some other things firstly, so
>>>> maybe my next email reply will be late (may tomorrow, or the day after
>>>> tomorrow).
>>>>
>>>>
>>>> Thanks.
>>>> --
>>>> Chen Gang
>>>>
>>>> Open, share, and attitude like air, water, and life which God blessed
>>>
>>> That's what I meant. If you can sent me a link to how to do build testing
>>> that would be great :).
>>
>> Please read README at the root directory of kernel source, also
>> "./Documents" contents many valuable information. And try google search
>> for additional information.
>>
>> Try to accomplish them by yourself, that will let yourself improved with
>> efficiency.
>>
>> Thanks.
>> --
>> Chen Gang
>>
>> Open, share, and attitude like air, water, and life which God blessed
>
> That seems to be the issue with my programming here.

For me, constructing related environments is necessary for developers,
especially for senior developers.

Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

2014-07-25 03:39:12

[permalink] [raw]

Subject: Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang <[email protected]> wrote:
>
>
> On 07/25/2014 11:30 AM, Nick Krause wrote:
>> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang <[email protected]> wrote:
>>>
>>>
>>> On 07/25/2014 11:13 AM, Nick Krause wrote:
>>>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang <[email protected]> wrote:
>>>>>
>>>>>
>>>>> On 07/25/2014 10:53 AM, Nick Krause wrote:
>>>>>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang <[email protected]> wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 07/25/2014 10:20 AM, Nick Krause wrote:
>>>>>>>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang <[email protected]> wrote:
>>>>>>>>>
>>>>>>>>> Excuse me, I did not see the patch details, but I guess it is about
>>>>>>>>> whether welcome a new member to upstream kernel. For me, I have 3 ideas
>>>>>>>>> about it if I am a newbie or a normal kernel developer:
>>>>>>>>>
>>>>>>>>> - Do I have enough basic skills for it?
>>>>>>>>>
>>>>>>>>> - Do I developed one or more another real world projects with C?
>>>>>>>>> (they are successful projects -- at least, not failure projects)
>>>>>>>>>
>>>>>>>>> - Can I construct related develop environments to support what I do?
>>>>>>>>> (e.g. building and testing for upstream kernel)
>>>>>>>>>
>>>>>>>>> - Am I familiar the basic working flow about kernel mailing list.
>>>>>>>>> (e.g. format-patch, sending patch, email client configuration...).
>>>>>>>>>
>>>>>>>>> - Do I have a correct attitude on it?
>>>>>>>>>
>>>>>>>>> - Am I careful enough?
>>>>>>>>> (e.g. if find some details may doubt, try to check and clear them)
>>>>>>>>> (it is always neccessary for all patches)
>>>>>>>>>
>>>>>>>>> - Am I try my best for it?
>>>>>>>>> (e.g. when finish coding, try what I can do: build, run and test).
>>>>>>>>> (it is neccessary for most cases)
>>>>>>>>>
>>>>>>>>> - Do I have negative effect with others?
>>>>>>>>> (e.g. discourage the newbies, or send spam to other members ...).
>>>>>>>>> (need always try to avoid)
>>>>>>>>>
>>>>>>>>> - Do I really love programming, also love open source kernel?
>>>>>>>>>
>>>>>>>>> - Do I love it, or I have to do it for another reason?
>>>>>>>>> (I guess, most of gmail members in open source, love programming).
>>>>>>>>>
>>>>>>>>> - Do I still love programming if I am discouraged by any members?
>>>>>>>>>
>>>>>>>>> - Do I still love open source kernel if discouraged by any members?
>>>>>>>>>
>>>>>>>>>
>>>>>>>> I have most of these skills other then developing real projects in C with other
>>>>>>>> developers as other then the kernel I don't have must interest in C outside
>>>>>>>> of embedded programming.
>>>>>>>
>>>>>>> OK, thanks. If what you said is true, for me, if you will, please still
>>>>>>> continue for open source kernel, but really need be more careful about
>>>>>>> the patch you made before send to open mailing list.
>>>>>>>
>>>>>>>
>>>>>>> Thanks.
>>>>>>> --
>>>>>>> Chen Gang
>>>>>>>
>>>>>>> Open, share, and attitude like air, water, and life which God blessed
>>>>>>
>>>>>> Chen ,
>>>>>> Thanks for helping me out here :). The true through is I don't known how to
>>>>>> build test correctly as a newb and thought it was better just to avoid it(stupid
>>>>>> me). I would like to known how to do this and if there is any way I can help you
>>>>>> guys out , please let me known :). I don't want to be avoided I am honestly here
>>>>>> to help make your life easier.
>>>>>
>>>>> Excuse me, my English is not quite well, I do not understand what you
>>>>> said, I guess your meaning is "not familiar with how to build and test
>>>>> upstream kernel" If what I guess is incorrect, please let me know.
>>>>>
>>>>> There are some books or some related web links for building and test
>>>>> kernel, they are not quite difficult to get (please google search).
>>>>>
>>>>> I guess, it is necessary to reference these information and construct
>>>>> related develop environments to support what you want to do next.
>>>>>
>>>>>
>>>>> By the way, excuse me, today I have to do some other things firstly, so
>>>>> maybe my next email reply will be late (may tomorrow, or the day after
>>>>> tomorrow).
>>>>>
>>>>>
>>>>> Thanks.
>>>>> --
>>>>> Chen Gang
>>>>>
>>>>> Open, share, and attitude like air, water, and life which God blessed
>>>>
>>>> That's what I meant. If you can sent me a link to how to do build testing
>>>> that would be great :).
>>>
>>> Please read README at the root directory of kernel source, also
>>> "./Documents" contents many valuable information. And try google search
>>> for additional information.
>>>
>>> Try to accomplish them by yourself, that will let yourself improved with
>>> efficiency.
>>>
>>> Thanks.
>>> --
>>> Chen Gang
>>>
>>> Open, share, and attitude like air, water, and life which God blessed
>>
>> That seems to be the issue with my programming here.
>
> For me, constructing related environments is necessary for developers,
> especially for senior developers.
>
>
> Thanks.
> --
> Chen Gang
>
> Open, share, and attitude like air, water, and life which God blessed
Thanks Chen,
Seems I don't need any more advice.
Nick

2014-07-25 04:34:10