2014-02-21 01:12:54

by Daeseok Youn

Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

>From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
From: Daeseok Youn <[email protected]>
Date: Fri, 21 Feb 2014 08:39:08 +0900
Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

sparse says:

drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
Using plain integer as NULL pointer
drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <[email protected]>
---
drivers/scsi/be2iscsi/be_cmds.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c
index 3338391..1ec9793 100644
--- a/drivers/scsi/be2iscsi/be_cmds.c
+++ b/drivers/scsi/be2iscsi/be_cmds.c
@@ -24,9 +24,9 @@
int beiscsi_pci_soft_reset(struct beiscsi_hba *phba)
{
u32 sreset;
- u8 *pci_reset_offset = 0;
- u8 *pci_online0_offset = 0;
- u8 *pci_online1_offset = 0;
+ u8 *pci_reset_offset = NULL;
+ u8 *pci_online0_offset = NULL;
+ u8 *pci_online1_offset = NULL;
u32 pconline0 = 0;
u32 pconline1 = 0;
u32 i;
--
1.7.9.5

2014-04-08 01:09:58

by Daeseok Youn

Subject: Re: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer

Hi,

This patch didn't apply. Please check for me.
Thanks.
Daeseok Youn

2014-03-12 2:02 GMT+09:00 Jayamohan Kallickal <[email protected]>:
>
>
> -----Original Message-----
> From: Daeseok Youn [mailto:[email protected]]
> Sent: Thursday, February 20, 2014 5:13 PM
> To: [email protected]
> Cc: Jayamohan Kallickal; [email protected]; [email protected]
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> From b483ef302f7d77c586949ae170754d589e8a4935 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <[email protected]>
> Date: Fri, 21 Feb 2014 08:39:08 +0900
> Subject: [PATCH] [SCSI] be2iscsi: use NULL instead of 0 for pointer
>
> sparse says:
>
> drivers/scsi/be2iscsi/be_cmds.c:27:32: warning:
> Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:28:34: warning:
> Using plain integer as NULL pointer
> drivers/scsi/be2iscsi/be_cmds.c:29:34: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <[email protected]>
> ---
> drivers/scsi/be2iscsi/be_cmds.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/be2iscsi/be_cmds.c b/drivers/scsi/be2iscsi/be_cmds.c index 3338391..1ec9793 100644
> --- a/drivers/scsi/be2iscsi/be_cmds.c
> +++ b/drivers/scsi/be2iscsi/be_cmds.c
> @@ -24,9 +24,9 @@
> int beiscsi_pci_soft_reset(struct beiscsi_hba *phba) {
> u32 sreset;
> - u8 *pci_reset_offset = 0;
> - u8 *pci_online0_offset = 0;
> - u8 *pci_online1_offset = 0;
> + u8 *pci_reset_offset = NULL;
> + u8 *pci_online0_offset = NULL;
> + u8 *pci_online1_offset = NULL;
> u32 pconline0 = 0;
> u32 pconline1 = 0;
> u32 i;
> --
> 1.7.9.5
>
> Acked-By: Jayamohan Kallickal <[email protected]>
>
> --