2014-01-02 22:43:10

by Bryan Wu

Subject: Re: [PATCH] leds: s3c24xx: Fix build failure

On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <[email protected]> wrote:
> Fixes following build error.
> drivers/leds/leds-s3c24xx.c: In function ?s3c24xx_led_probe?:
> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
> function ?s3c_gpio_setpull? [-Werror=implicit-function-declaration]
>

I don't see any building error with s3c2410_defconfig. Actually this
<plat/gpio-cfg.h> is included in
arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
arch/arm/include/asm/gpio.h, then <linux/gpio.h>

Thanks,
-Bryan

> Signed-off-by: Tushar Behera <[email protected]>
> ---
> Tested at next-20131224.
>
> drivers/leds/leds-s3c24xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/leds/leds-s3c24xx.c b/drivers/leds/leds-s3c24xx.c
> index 76483fb..87cf215 100644
> --- a/drivers/leds/leds-s3c24xx.c
> +++ b/drivers/leds/leds-s3c24xx.c
> @@ -21,6 +21,7 @@
>
> #include <mach/hardware.h>
> #include <mach/regs-gpio.h>
> +#include <plat/gpio-cfg.h>
> #include <linux/platform_data/leds-s3c24xx.h>
>
> /* our context */
> --
> 1.7.9.5
>

2014-01-03 05:05:05

by Tushar Behera

Subject: Re: [PATCH] leds: s3c24xx: Fix build failure

On 3 January 2014 04:12, Bryan Wu <[email protected]> wrote:
> On Mon, Dec 30, 2013 at 1:09 AM, Tushar Behera <[email protected]> wrote:
>> Fixes following build error.
>> drivers/leds/leds-s3c24xx.c: In function ‘s3c24xx_led_probe’:
>> drivers/leds/leds-s3c24xx.c:100:2: error: implicit declaration of
>> function ‘s3c_gpio_setpull’ [-Werror=implicit-function-declaration]
>>
>
> I don't see any building error with s3c2410_defconfig. Actually this
> <plat/gpio-cfg.h> is included in
> arch/arm/mach-s3c24xx/include/mach/gpio.h which is in
> arch/arm/include/asm/gpio.h, then <linux/gpio.h>
>

This requires that CONFIG_NEED_MACH_GPIO_H is defined. Following
commit has removed this option for s3c24xx platform.

c67d0f29262b ("ARM: s3c24xx: get rid of custom <mach/gpio.h>").

--
Tushar Behera