2023-07-17 07:28:11

by Minjie Du

Subject: [PATCH v1] gfs2: increase usage of folio_next_index() helper

Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
the existing helper folio_next_index().

Signed-off-by: Minjie Du <[email protected]>
---
fs/gfs2/aops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index ae49256b7..5f0254237 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
* not be suitable for data integrity
* writeout).
*/
- *done_index = folio->index +
- folio_nr_pages(folio);
+ *done_index = folio_next_index(folio);
ret = 1;
break;
}
--
2.39.0

2023-07-17 08:03:39

by Andreas Gruenbacher

Subject: Re: [PATCH v1] gfs2: increase usage of folio_next_index() helper

Minjie,

On Mon, Jul 17, 2023 at 9:20 AM Minjie Du <[email protected]> wrote:
> Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using
> the existing helper folio_next_index().
>
> Signed-off-by: Minjie Du <[email protected]>
> ---
> fs/gfs2/aops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
> index ae49256b7..5f0254237 100644
> --- a/fs/gfs2/aops.c
> +++ b/fs/gfs2/aops.c
> @@ -272,8 +272,7 @@ static int gfs2_write_jdata_batch(struct address_space *mapping,
> * not be suitable for data integrity
> * writeout).
> */
> - *done_index = folio->index +
> - folio_nr_pages(folio);
> + *done_index = folio_next_index(folio);
> ret = 1;
> break;
> }
> --
> 2.39.0
>

Applied, thanks.

Email addresses like '"open list:GFS2 FILE SYSTEM"
<[email protected]>' and 'open list
<[email protected]>' are not helpful though, so could you
please avoid using addresses like that in the future?

Thanks,
Andreas