Hi Linus, this fixes a riscv randconfig build failure from memory
allocation profiling...
Did some more local randconfig build testing for this one, as well as
had 0day test it.
The following changes since commit d960f67701b21b945a3fb5b6555aa4a97062fcd0:
Merge tag 'nfs-for-6.10-1' of git://git.linux-nfs.org/projects/trondmy/linux-nfs (2024-05-24 11:42:03 -0400)
are available in the Git repository at:
https://evilpiepirate.org/git/bcachefs.git fix_missing_include
for you to fetch changes up to acb7ffcaeaa6793fecf71decbe41ed2ff4422ad1:
bcachefs: Include smp.h in alloc_tag.h (2024-05-24 11:42:09 -0400)
----------------------------------------------------------------
Kent Overstreet (1):
bcachefs: Include smp.h in alloc_tag.h
include/linux/alloc_tag.h | 1 +
1 file changed, 1 insertion(+)
On Sun, 26 May 2024 at 10:03, Kent Overstreet <[email protected]> wrote:
>
> Hi Linus, this fixes a riscv randconfig build failure from memory
> allocation profiling...
This pull request is odd in multiple ways.
(a) it's unsigned, and I really don't pull from unsigned sources any more
(b) the commit message is strange. It says "bcachefs", but I don't see why
(c) you say riscv randconfig in the pull request but then when I
follow the links in the commit, it says "mips-randconfig". Maybe the
same thing ends up happening elsewhere too - including riscv - but it
sure is confusing and I suspect it was just a typo.
(d) there's no "Fixes:" tag, so then I had to go and look up that
this wasn't stable material (it doesn't seem to be, the "Fixes" tag
would seem to be 24e44cc22aa3 ("mm: percpu: enable per-cpu allocation
tagging") from the current merge window
All of which means that I ended up just fetching the patch, fixing up
the commit message, and applying it manually instead.
Linus
On Sun, May 26, 2024 at 02:46:04PM -0700, Linus Torvalds wrote:
> On Sun, 26 May 2024 at 10:03, Kent Overstreet <[email protected]> wrote:
> >
> > Hi Linus, this fixes a riscv randconfig build failure from memory
> > allocation profiling...
>
> This pull request is odd in multiple ways.
>
> (a) it's unsigned, and I really don't pull from unsigned sources any more
I thought it'd be fine since it's a one liner - I'll fix that
> (b) the commit message is strange. It says "bcachefs", but I don't see why
blech, muscle memory...
> (c) you say riscv randconfig in the pull request but then when I
> follow the links in the commit, it says "mips-randconfig". Maybe the
> same thing ends up happening elsewhere too - including riscv - but it
> sure is confusing and I suspect it was just a typo.
Yeah, another typo
> (d) there's no "Fixes:" tag, so then I had to go and look up that
> this wasn't stable material (it doesn't seem to be, the "Fixes" tag
> would seem to be 24e44cc22aa3 ("mm: percpu: enable per-cpu allocation
> tagging") from the current merge window
yeah, I should have added that.
Sorry for the confusion...
On Sun, 26 May 2024 at 14:57, Kent Overstreet <[email protected]> wrote:
>
> > (a) it's unsigned, and I really don't pull from unsigned sources any more
>
> I thought it'd be fine since it's a one liner - I'll fix that
Oh, I certainly considered just making an exception for it being
trivial, and if that had been the only issue, I would have just
grumbled and done that.
But since I felt the oneliner fix was paired with a commit that needed
rewriting anyway...
Linus