2020-12-10 11:35:57

by Jason A. Donenfeld

[permalink] [raw]
Subject: Re: [PATCH] wireguard: avoid double unlikely() notation when using IS_ERR()

On Thu, Dec 10, 2020 at 9:56 AM Antonio Quartulli <[email protected]> wrote:
>
> The definition of IS_ERR() already applies the unlikely() notation
> when checking the error status of the passed pointer. For this
> reason there is no need to have the same notation outside of
> IS_ERR() itself.
>
> Clean up code by removing redundant notation.

Thanks for the patch. I can confirm this doesn't change the codgen at all.

I've queued this up in wireguard's staging tree, and I'll push it back
out as part of the next series.

Jason