2023-07-17 21:07:04

by Samuel Holland

Subject: [PATCH 1/2] of/irq: Export of_irq_count()

This function is used by the SiFive GPIO driver. Export it so that
driver can be built as a module.

Signed-off-by: Samuel Holland <[email protected]>
---

drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 174900072c18..9cea7632dd6a 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -489,6 +489,7 @@ int of_irq_count(struct device_node *dev)

return nr;
}
+EXPORT_SYMBOL_GPL(of_irq_count);

/**
* of_irq_to_resource_table - Fill in resource table with node's IRQ info
--
2.40.1

2023-07-17 21:51:37

by Andy Shevchenko

Subject: Re: [PATCH 1/2] of/irq: Export of_irq_count()

On Mon, Jul 17, 2023 at 11:54 PM Samuel Holland
<[email protected]> wrote:
>
> This function is used by the SiFive GPIO driver. Export it so that
> driver can be built as a module.

Can we rather reduce use of of_*() APIs?
For example, why not use platform_irq_count()?

--
With Best Regards,
Andy Shevchenko

2023-07-18 23:49:57

by Rob Herring (Arm)

Subject: Re: [PATCH 1/2] of/irq: Export of_irq_count()

On Tue, Jul 18, 2023 at 12:40:53AM +0300, Andy Shevchenko wrote:
> On Mon, Jul 17, 2023 at 11:54 PM Samuel Holland
> <[email protected]> wrote:
> >
> > This function is used by the SiFive GPIO driver. Export it so that
> > driver can be built as a module.
>
> Can we rather reduce use of of_*() APIs?
> For example, why not use platform_irq_count()?

+1