2023-08-10 14:44:49

by coolrrsh

Subject: [PATCH v3] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

From: Rajeshwar R Shinde <[email protected]>

Use of macro ARRAY_SIZE to calculate array size minimizes
the redundant code and improves code reusability.
This fixes warnings reported by Coccinelle:
drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE

Signed-off-by: Rajeshwar R Shinde <[email protected]>
---
v1->v2
ARRAY_SIZE calculates array length, so changed
gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)/sizeof(unsigned int) to
gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)

v2->v3
added linux/kernel.h containing ARRAY_SIZE definition

---
drivers/gpio/gpio-imx-scu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
index e190bde5397d..13baf465aedf 100644
--- a/drivers/gpio/gpio-imx-scu.c
+++ b/drivers/gpio/gpio-imx-scu.c
@@ -6,6 +6,7 @@
* to control the PIN resources on SCU domain.
*/

+#include <linux/kernel.h>
#include <linux/module.h>
#include <linux/gpio/driver.h>
#include <linux/platform_device.h>
@@ -103,7 +104,7 @@ static int imx_scu_gpio_probe(struct platform_device *pdev)
gc = &priv->chip;
gc->base = -1;
gc->parent = dev;
- gc->ngpio = sizeof(scu_rsrc_arr)/sizeof(unsigned int);
+ gc->ngpio = ARRAY_SIZE(scu_rsrc_arr);
gc->label = dev_name(dev);
gc->get = imx_scu_gpio_get;
gc->set = imx_scu_gpio_set;
--
2.25.1

2023-08-10 15:48:05

by Andy Shevchenko

Subject: Re: [PATCH v3] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

On Thu, Aug 10, 2023 at 4:06 PM <[email protected]> wrote:
>
> From: Rajeshwar R Shinde <[email protected]>
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> This fixes warnings reported by Coccinelle:
> drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE

Yes and this makes code more robust against type changes.
Reviewed-by: Andy Shevchenko <[email protected]>

--
With Best Regards,
Andy Shevchenko

2023-08-11 16:16:39

by Bartosz Golaszewski

Subject: Re: [PATCH v3] gpio: gpio-imx-scu: Use ARRAY_SIZE for array length

On Thu, Aug 10, 2023 at 3:06 PM <[email protected]> wrote:
>
> From: Rajeshwar R Shinde <[email protected]>
>
> Use of macro ARRAY_SIZE to calculate array size minimizes
> the redundant code and improves code reusability.
> This fixes warnings reported by Coccinelle:
> drivers/gpio/gpio-imx-scu.c:106:32-33: WARNING: Use ARRAY_SIZE
>
> Signed-off-by: Rajeshwar R Shinde <[email protected]>
> ---
> v1->v2
> ARRAY_SIZE calculates array length, so changed
> gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)/sizeof(unsigned int) to
> gc->ngpio = ARRAY_SIZE(scu_rsrc_arr)
>
> v2->v3
> added linux/kernel.h containing ARRAY_SIZE definition
>
> ---
> drivers/gpio/gpio-imx-scu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-imx-scu.c b/drivers/gpio/gpio-imx-scu.c
> index e190bde5397d..13baf465aedf 100644
> --- a/drivers/gpio/gpio-imx-scu.c
> +++ b/drivers/gpio/gpio-imx-scu.c
> @@ -6,6 +6,7 @@
> * to control the PIN resources on SCU domain.
> */
>
> +#include <linux/kernel.h>
> #include <linux/module.h>
> #include <linux/gpio/driver.h>
> #include <linux/platform_device.h>
> @@ -103,7 +104,7 @@ static int imx_scu_gpio_probe(struct platform_device *pdev)
> gc = &priv->chip;
> gc->base = -1;
> gc->parent = dev;
> - gc->ngpio = sizeof(scu_rsrc_arr)/sizeof(unsigned int);
> + gc->ngpio = ARRAY_SIZE(scu_rsrc_arr);
> gc->label = dev_name(dev);
> gc->get = imx_scu_gpio_get;
> gc->set = imx_scu_gpio_set;
> --
> 2.25.1
>

The commit title should be "gpio: imx-scu: ..."

I fixed it and applied.

Bart