On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index 366161cff560..7206d29ba263 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -1715,6 +1715,12 @@ void atomisp_wdt_refresh_pipe(struct atomisp_video_pipe *pipe,
> {
> unsigned long next;
>
> + if(!pipe->asd) {
Run your patches through scripts/checkpatch.pl.
> + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> + __func__, pipe->vdev.name);
> + return;
> + }
regards,
dan carpenter
On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <[email protected]> wrote:
> On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> > + if(!pipe->asd) {
>
> Run your patches through scripts/checkpatch.pl.
While it's good advice, we are dealing with quite a bad code under
staging, so the requirements may be relaxed.
> > + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> > + __func__, pipe->vdev.name);
> > + return;
> > + }
--
With Best Regards,
Andy Shevchenko
On Tue, Nov 2, 2021 at 4:44 PM Andy Shevchenko
<[email protected]> wrote:
> On Tue, Nov 2, 2021 at 3:10 PM Dan Carpenter <[email protected]> wrote:
> > On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
...
> > Run your patches through scripts/checkpatch.pl.
>
> While it's good advice, we are dealing with quite a bad code under
> staging, so the requirements may be relaxed.
To be more clear: the goal now is getting it _working_. That's why
this kind of noise is not important _for now_.
--
With Best Regards,
Andy Shevchenko
<removed Alan from Cc as the mail address not reachable>
On Tue, 2021-11-02 at 16:02 +0300, Dan Carpenter wrote:
> On Mon, Oct 18, 2021 at 01:23:34AM +0900, Tsuchiya Yuto wrote:
> > diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > index 366161cff560..7206d29ba263 100644
> > --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> > @@ -1715,6 +1715,12 @@ void atomisp_wdt_refresh_pipe(struct atomisp_video_pipe *pipe,
> > {
> > unsigned long next;
> >
> > + if(!pipe->asd) {
>
> Run your patches through scripts/checkpatch.pl.
I'm sorry about this. I did checkpatch for another series I sent earlier,
but forgot this series.
Regards,
Tsuchiya Yuto
> > + dev_err(pipe->isp->dev, "%s(): asd is NULL, device is %s\n",
> > + __func__, pipe->vdev.name);
> > + return;
> > + }
>
> regards,
> dan carpenter
>