LinuxLists.cc - linux-next: build failure after merge of the sound tree

2022-07-15 12:52:46

Subject: linux-next: build failure after merge of the sound tree

Hi all,

After merging the sound tree, today's linux-next build (powerpc
allyesconfig) failed like this:

sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
| ^~

Caused by commit

d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")

along with commit

eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")

I have reverted commit d60b05b4c780 for today.

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-07-15 16:01:25

by Takashi Iwai

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the sound tree

On Fri, 15 Jul 2022 14:44:43 +0200,
Stephen Rothwell wrote:
>
> Hi all,
>
> After merging the sound tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
> sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
> 693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
> | ^~
>
> Caused by commit
>
> d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
>
> along with commit
>
> eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
>
> I have reverted commit d60b05b4c780 for today.

Thanks. Now I reverted the commit on for-next branch as a workaround,
too.

Takashi

2022-07-15 19:30:41

by Andy Shevchenko

[permalink] [raw]

Subject: Re: linux-next: build failure after merge of the sound tree

On Fri, Jul 15, 2022 at 5:39 PM Takashi Iwai <[email protected]> wrote:
>
> On Fri, 15 Jul 2022 14:44:43 +0200,
> Stephen Rothwell wrote:
> >
> > Hi all,
> >
> > After merging the sound tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > sound/pci/hda/cs35l41_hda.c: In function 'cs35l41_get_acpi_sub_string':
> > sound/pci/hda/cs35l41_hda.c:693:43: error: invalid use of undefined type 'struct acpi_device'
> > 693 | status = acpi_evaluate_object(adev->handle, "_SUB", NULL, &buffer);
> > | ^~
> >
> > Caused by commit
> >
> > d60b05b4c780 ("ALSA: hda: cs35l41: Allow compilation test on non-ACPI configurations")
> >
> > along with commit
> >
> > eef375960210 ("ALSA: hda: cs35l41: Support reading subsystem id from ACPI")
> >
> > I have reverted commit d60b05b4c780 for today.
>
> Thanks. Now I reverted the commit on for-next branch as a workaround,
> too.

Thanks! OTOH it means it's working well :-)

Nevertheless, I have prepared a series to deduplicate this _SUB code
and I think the ACPI would stay as a compile dependency because of
that change anyway.

--
With Best Regards,
Andy Shevchenko