2021-07-15 19:53:17

by Linus Walleij

Subject: [PATCH] extcon: usb-gpio: Use the right includes

The USB GPIO extcon driver does not use any of the legacy
includes <linux/gpio.h> or <linux/of_gpio.h> but
exploits the fact that this brings in <linux/mod_device_table.h>.
Fix this up by using the right includes.

Signed-off-by: Linus Walleij <[email protected]>
---
drivers/extcon/extcon-usb-gpio.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
index f06be6d4e2a9..0cb440bdd5cb 100644
--- a/drivers/extcon/extcon-usb-gpio.c
+++ b/drivers/extcon/extcon-usb-gpio.c
@@ -7,18 +7,17 @@
*/

#include <linux/extcon-provider.h>
-#include <linux/gpio.h>
#include <linux/gpio/consumer.h>
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/of_gpio.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/pinctrl/consumer.h>
+#include <linux/mod_devicetable.h>

#define USB_GPIO_DEBOUNCE_MS 20 /* ms */

--
2.31.1

2021-07-15 21:38:13

by Andy Shevchenko

Subject: Re: [PATCH] extcon: usb-gpio: Use the right includes

On Thu, Jul 15, 2021 at 10:35 PM Linus Walleij <[email protected]> wrote:
>
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.

I like it!
Only one comment below, after addressing,
Reviewed-by: Andy Shevchenko <[email protected]>

>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>

> +#include <linux/mod_devicetable.h>

Can it be squeezed more or less in an ordered manner?
(before module.h I suppose)

>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
> --
> 2.31.1
>


--
With Best Regards,
Andy Shevchenko

2021-07-23 05:30:01

by Chanwoo Choi

Subject: Re: [PATCH] extcon: usb-gpio: Use the right includes

On 7/16/21 4:06 AM, Linus Walleij wrote:
> The USB GPIO extcon driver does not use any of the legacy
> includes <linux/gpio.h> or <linux/of_gpio.h> but
> exploits the fact that this brings in <linux/mod_device_table.h>.
> Fix this up by using the right includes.
>
> Signed-off-by: Linus Walleij <[email protected]>
> ---
> drivers/extcon/extcon-usb-gpio.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index f06be6d4e2a9..0cb440bdd5cb 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -7,18 +7,17 @@
> */
>
> #include <linux/extcon-provider.h>
> -#include <linux/gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/irq.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> -#include <linux/of_gpio.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/workqueue.h>
> #include <linux/pinctrl/consumer.h>
> +#include <linux/mod_devicetable.h>
>
> #define USB_GPIO_DEBOUNCE_MS 20 /* ms */
>
>

Applied it. Thanks.

--
Best Regards,
Chanwoo Choi
Samsung Electronics