Hello,
On 2014-09-19 11:00, Marek Szyprowski wrote:
> Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
> clk provider only after registering its all clocks", merged to v3.17-rc1)
> modified a way that driver registers registers to core framework. This
> change has not been applied to s5pv210 clocks driver, which has been
> merged in parallel to that commit. This patch adds a missing call to
> samsung_clk_of_add_provider(), so the driver is operational again.
>
> Signed-off-by: Marek Szyprowski <[email protected]>
> ---
> Hello!
>
> This is an important fix to v3.17-rcX. Without it support for Samsung
> S5PV210 SoCs is not functional.
>
> Mike, could you take it to the fixes branch?
Mike: could you handle this patch? It looks it got missed for a few
releases...
> Best regards
> Marek Szyprowski, PhD
> Samsung R&D Institute Poland
> ---
> drivers/clk/samsung/clk-s5pv210.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clk/samsung/clk-s5pv210.c b/drivers/clk/samsung/clk-s5pv210.c
> index d270a20..f41b017 100644
> --- a/drivers/clk/samsung/clk-s5pv210.c
> +++ b/drivers/clk/samsung/clk-s5pv210.c
> @@ -828,6 +828,8 @@ static void __init __s5pv210_clk_init(struct device_node *np,
>
> s5pv210_clk_sleep_init();
>
> + samsung_clk_of_add_provider(np, ctx);
> +
> pr_info("%s clocks: mout_apll = %ld, mout_mpll = %ld\n"
> "\tmout_epll = %ld, mout_vpll = %ld\n",
> is_s5p6442 ? "S5P6442" : "S5PV210",
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
2015-08-07 23:10 GMT+09:00 Marek Szyprowski <[email protected]>:
> Hello,
>
> On 2014-09-19 11:00, Marek Szyprowski wrote:
>>
>> Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 ("clk: samsung: Register
>> clk provider only after registering its all clocks", merged to v3.17-rc1)
>> modified a way that driver registers registers to core framework. This
>> change has not been applied to s5pv210 clocks driver, which has been
>> merged in parallel to that commit. This patch adds a missing call to
>> samsung_clk_of_add_provider(), so the driver is operational again.
>>
>> Signed-off-by: Marek Szyprowski <[email protected]>
>> ---
>> Hello!
>>
>> This is an important fix to v3.17-rcX. Without it support for Samsung
>> S5PV210 SoCs is not functional.
>>
>> Mike, could you take it to the fixes branch?
>
>
> Mike: could you handle this patch? It looks it got missed for a few
> releases...
So maybe now it is worth backporting to stable?
Best regards,
Krzysztof