2022-05-16 18:17:13

by Hsin-Yi Wang

Subject: [PATCH 0/3] Implement readahead for squashfs

Commit c1f6925e1091("mm: put readahead pages in cache earlier") requires
fs to implement readahead callback. Otherwise there will be a
performance regression.

Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
disable read-ahead") mitigates the performance drop issue for squashfs
by closing readahead for it.

This series implements readahead callback for squashfs. The previous
discussion are in [1] and [2].

[1] https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
[2] https://lore.kernel.org/linux-mm/[email protected]/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1

Hsin-Yi Wang (3):
Revert "squashfs: Convert squashfs to read_folio"
Revert "squashfs: provide backing_dev_info in order to disable
read-ahead"
squashfs: implement readahead

fs/squashfs/file.c | 82 +++++++++++++++++++++++++++++++++++++++++--
fs/squashfs/super.c | 33 -----------------
fs/squashfs/symlink.c | 5 ++-
3 files changed, 81 insertions(+), 39 deletions(-)

--
2.36.0.550.gb090851708-goog

2022-05-17 00:51:48

by Hsin-Yi Wang

Subject: Re: [PATCH 0/3] Implement readahead for squashfs

On Mon, May 16, 2022 at 6:42 PM Hsin-Yi Wang <[email protected]> wrote:
>
> Commit c1f6925e1091("mm: put readahead pages in cache earlier") requires
> fs to implement readahead callback. Otherwise there will be a
> performance regression.
>
> Commit 9eec1d897139("squashfs: provide backing_dev_info in order to
> disable read-ahead") mitigates the performance drop issue for squashfs
> by closing readahead for it.
>
> This series implements readahead callback for squashfs. The previous
> discussion are in [1] and [2].
>
> [1] https://lore.kernel.org/all/CAJMQK-g9G6KQmH-V=BRGX0swZji9Wxe_2c7ht-MMAapdFy2pXw@mail.gmail.com/T/
> [2] https://lore.kernel.org/linux-mm/[email protected]/t/#m4af4473b94f98a4996cb11756b633a07e5e059d1
>
> Hsin-Yi Wang (3):
> Revert "squashfs: Convert squashfs to read_folio"
> Revert "squashfs: provide backing_dev_info in order to disable
> read-ahead"
> squashfs: implement readahead
>
> fs/squashfs/file.c | 82 +++++++++++++++++++++++++++++++++++++++++--
> fs/squashfs/super.c | 33 -----------------
> fs/squashfs/symlink.c | 5 ++-
> 3 files changed, 81 insertions(+), 39 deletions(-)
>
> --
> 2.36.0.550.gb090851708-goog
>

hi, please ignore this for now. I'll resend a correct cover letter.