2022-05-19 09:27:02

by Pin-yen Lin

Subject: [PATCH] arm64: dts: mt8173: Fix elm panel DT node

Move the panel DT node under `aux-bus` node so it won't use the buggy
`ps8640_bridge_get_edid` to get display modes. Also change the
compatible string to "edp-panel" because the predefined
`lg_lp129qe_mode` is not working.

Signed-off-by: Pin-Yen Lin <[email protected]>
Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")
---

arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
1 file changed, 14 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
index 9c75fbb31f98..1e0802a6f6d2 100644
--- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
@@ -90,18 +90,6 @@ volume_up {
};
};

- panel: panel {
- compatible = "lg,lp120up1";
- power-supply = <&panel_fixed_3v3>;
- backlight = <&backlight>;
-
- port {
- panel_in: endpoint {
- remote-endpoint = <&ps8640_out>;
- };
- };
- };
-
panel_fixed_3v3: regulator1 {
compatible = "regulator-fixed";
regulator-name = "PANEL_3V3";
@@ -282,6 +270,20 @@ ps8640_out: endpoint {
};
};
};
+
+ aux-bus {
+ panel {
+ compatible = "edp-panel";
+ power-supply = <&panel_fixed_3v3>;
+ backlight = <&backlight>;
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&ps8640_out>;
+ };
+ };
+ };
+ };
};
};

--
2.36.1.124.g0e6072fb45-goog

2022-05-21 13:45:30

by Hsin-Yi Wang

Subject: Re: [PATCH] arm64: dts: mt8173: Fix elm panel DT node

On Thu, May 19, 2022 at 3:27 PM Pin-Yen Lin <[email protected]> wrote:
>
> Move the panel DT node under `aux-bus` node so it won't use the buggy
> `ps8640_bridge_get_edid` to get display modes. Also change the
> compatible string to "edp-panel" because the predefined
> `lg_lp129qe_mode` is not working.
>
> Signed-off-by: Pin-Yen Lin <[email protected]>
> Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board")

Acked-by: Hsin-Yi Wang <[email protected]>

> ---
>
> arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 26 +++++++++++---------
> 1 file changed, 14 insertions(+), 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 9c75fbb31f98..1e0802a6f6d2 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -90,18 +90,6 @@ volume_up {
> };
> };
>
> - panel: panel {
> - compatible = "lg,lp120up1";
> - power-supply = <&panel_fixed_3v3>;
> - backlight = <&backlight>;
> -
> - port {
> - panel_in: endpoint {
> - remote-endpoint = <&ps8640_out>;
> - };
> - };
> - };
> -
> panel_fixed_3v3: regulator1 {
> compatible = "regulator-fixed";
> regulator-name = "PANEL_3V3";
> @@ -282,6 +270,20 @@ ps8640_out: endpoint {
> };
> };
> };
> +
> + aux-bus {
> + panel {
> + compatible = "edp-panel";
> + power-supply = <&panel_fixed_3v3>;
> + backlight = <&backlight>;
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&ps8640_out>;
> + };
> + };
> + };
> + };
> };
> };
>
> --
> 2.36.1.124.g0e6072fb45-goog
>