2022-08-25 09:27:09

by shijm

Subject: [PATCH] tools: Delete the initialization value

From: Shi junming <[email protected]>

From the perspective of commpier,delete the initialization value

Signed-off-by: Shi junming <[email protected]>
---
tools/power/acpi/tools/pfrut/pfrut.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
index d79c335594b2..52aa0351533c 100644
--- a/tools/power/acpi/tools/pfrut/pfrut.c
+++ b/tools/power/acpi/tools/pfrut/pfrut.c
@@ -190,7 +190,7 @@ int main(int argc, char *argv[])
void *addr_map_capsule;
struct stat st;
char *log_buf;
- int ret = 0;
+ int ret;

if (getuid() != 0) {
printf("Please run the tool as root - Exiting.\n");
--
2.18.2

2022-08-25 11:37:52

by Rafael J. Wysocki

Subject: Re: [PATCH] tools: Delete the initialization value

On Thu, Aug 25, 2022 at 11:04 AM shijm <[email protected]> wrote:
>
> From: Shi junming <[email protected]>
>
> From the perspective of commpier,delete the initialization value

I'm not sure what this means.

The initialization is unnecessary, because the variable in question is
always assigned a new value before reading it. Is that what you
wanted to say?

> Signed-off-by: Shi junming <[email protected]>
> ---
> tools/power/acpi/tools/pfrut/pfrut.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/acpi/tools/pfrut/pfrut.c b/tools/power/acpi/tools/pfrut/pfrut.c
> index d79c335594b2..52aa0351533c 100644
> --- a/tools/power/acpi/tools/pfrut/pfrut.c
> +++ b/tools/power/acpi/tools/pfrut/pfrut.c
> @@ -190,7 +190,7 @@ int main(int argc, char *argv[])
> void *addr_map_capsule;
> struct stat st;
> char *log_buf;
> - int ret = 0;
> + int ret;
>
> if (getuid() != 0) {
> printf("Please run the tool as root - Exiting.\n");
> --
> 2.18.2
>

2022-08-29 03:43:22

by shijm

Subject: Re: [PATCH] tools: Delete the initialization value

yes,just your said!

2022-09-03 18:55:45

by Rafael J. Wysocki

Subject: Re: [PATCH] tools: Delete the initialization value

On Mon, Aug 29, 2022 at 5:06 AM shijm <[email protected]> wrote:
>
> yes,just your said!

OK

I've applied the patch as 6.1 material under a new subject and with a
new changelog.

Thanks!