2023-11-23 07:00:32

by Arnd Bergmann

Subject: [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes

From: Arnd Bergmann <[email protected]>

The newly added functions are declared in a header that is not included
before the definition:

drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~
drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
| ^~~~~~~~~~~~~~~~~~~~~~~

Fixes: 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/acpi/thermal_lib.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
index 646ff6bda6dd..4e0519ca9739 100644
--- a/drivers/acpi/thermal_lib.c
+++ b/drivers/acpi/thermal_lib.c
@@ -9,6 +9,7 @@
#include <linux/acpi.h>
#include <linux/units.h>
#include <linux/thermal.h>
+#include "internal.h"

/*
* Minimum temperature for full military grade is 218°K (-55°C) and
--
2.39.2

2023-11-24 18:28:55

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: thermal_lib: include "internal.h" for function prototypes

On Thu, Nov 23, 2023 at 8:00 AM Arnd Bergmann <[email protected]> wrote:
>
> From: Arnd Bergmann <[email protected]>
>
> The newly added functions are declared in a header that is not included
> before the definition:
>
> drivers/acpi/thermal_lib.c:46:5: error: no previous prototype for 'acpi_active_trip_temp' [-Werror=missing-prototypes]
> 46 | int acpi_active_trip_temp(struct acpi_device *adev, int id, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:57:5: error: no previous prototype for 'acpi_passive_trip_temp' [-Werror=missing-prototypes]
> 57 | int acpi_passive_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:63:5: error: no previous prototype for 'acpi_hot_trip_temp' [-Werror=missing-prototypes]
> 63 | int acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~
> drivers/acpi/thermal_lib.c:69:5: error: no previous prototype for 'acpi_critical_trip_temp' [-Werror=missing-prototypes]
> 69 | int acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp)
> | ^~~~~~~~~~~~~~~~~~~~~~~
>
> Fixes: 6908097aa5a7 ("ACPI: thermal_lib: Add functions returning temperature in deci-Kelvin")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> drivers/acpi/thermal_lib.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 646ff6bda6dd..4e0519ca9739 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -9,6 +9,7 @@
> #include <linux/acpi.h>
> #include <linux/units.h>
> #include <linux/thermal.h>
> +#include "internal.h"
>
> /*
> * Minimum temperature for full military grade is 218°K (-55°C) and
> --

Applied, thanks!