2022-08-12 07:22:42

by zhaoxiao

Subject: [PATCH] thermal/drivers/da9062: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq()
already prints an error.

Signed-off-by: zhaoxiao <[email protected]>
---
drivers/thermal/da9062-thermal.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c
index 180edec34e07..7dcfde7a9f2c 100644
--- a/drivers/thermal/da9062-thermal.c
+++ b/drivers/thermal/da9062-thermal.c
@@ -248,10 +248,9 @@ static int da9062_thermal_probe(struct platform_device *pdev)
jiffies_to_msecs(thermal->zone->passive_delay_jiffies));

ret = platform_get_irq_byname(pdev, "THERMAL");
- if (ret < 0) {
- dev_err(&pdev->dev, "Failed to get platform IRQ.\n");
+ if (ret < 0)
goto err_zone;
- }
+
thermal->irq = ret;

ret = request_threaded_irq(thermal->irq, NULL,
--
2.20.1

2022-08-31 19:12:11

by Rafael J. Wysocki

Subject: Re: [PATCH] thermal/drivers/da9062: Remove unnecessary print function dev_err()

On Fri, Aug 12, 2022 at 8:40 AM zhaoxiao <[email protected]> wrote:
>
> The print function dev_err() is redundant because platform_get_irq()
> already prints an error.
>
> Signed-off-by: zhaoxiao <[email protected]>
> ---
> drivers/thermal/da9062-thermal.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/thermal/da9062-thermal.c b/drivers/thermal/da9062-thermal.c
> index 180edec34e07..7dcfde7a9f2c 100644
> --- a/drivers/thermal/da9062-thermal.c
> +++ b/drivers/thermal/da9062-thermal.c
> @@ -248,10 +248,9 @@ static int da9062_thermal_probe(struct platform_device *pdev)
> jiffies_to_msecs(thermal->zone->passive_delay_jiffies));
>
> ret = platform_get_irq_byname(pdev, "THERMAL");
> - if (ret < 0) {
> - dev_err(&pdev->dev, "Failed to get platform IRQ.\n");
> + if (ret < 0)
> goto err_zone;
> - }
> +
> thermal->irq = ret;
>
> ret = request_threaded_irq(thermal->irq, NULL,
> --

Applied as 6.1 material with subject and changelog edits, thanks!