2023-10-16 16:08:48

by Werner Sembach

Subject: [PATCH v2] ACPI: resource: Do IRQ override on TongFang GMxXGxx

The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding
for the keyboard to work. Adding an entry for this laptop to the
override_table makes the internal keyboard functional.

v2: Rebase onto linux-next

Signed-off-by: Werner Sembach <[email protected]>
Cc: <[email protected]>
---
drivers/acpi/resource.c | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index 18f6353c142e..15a3bdbd0755 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -497,6 +497,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
},
},
+ {
+ /* TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
+ },
+ },
+ {
+ /* TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD */
+ .matches = {
+ DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
+ },
+ },
{
/* MAINGEAR Vector Pro 2 15 */
.matches = {
--
2.34.1

2023-10-16 17:33:40

by Rafael J. Wysocki

Subject: Re: [PATCH v2] ACPI: resource: Do IRQ override on TongFang GMxXGxx

On Mon, Oct 16, 2023 at 6:08 PM Werner Sembach <[email protected]> wrote:
>
> The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding
> for the keyboard to work. Adding an entry for this laptop to the
> override_table makes the internal keyboard functional.
>
> v2: Rebase onto linux-next

Hans, any comments?

> Signed-off-by: Werner Sembach <[email protected]>
> Cc: <[email protected]>
> ---
> drivers/acpi/resource.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index 18f6353c142e..15a3bdbd0755 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -497,6 +497,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
> DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
> },
> },
> + {
> + /* TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD */
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
> + },
> + },
> + {
> + /* TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD */
> + .matches = {
> + DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
> + },
> + },
> {
> /* MAINGEAR Vector Pro 2 15 */
> .matches = {
> --
> 2.34.1
>

2023-10-16 18:39:25

by Hans de Goede

Subject: Re: [PATCH v2] ACPI: resource: Do IRQ override on TongFang GMxXGxx

Hi,

On 10/16/23 19:33, Rafael J. Wysocki wrote:
> On Mon, Oct 16, 2023 at 6:08 PM Werner Sembach <[email protected]> wrote:
>>
>> The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding
>> for the keyboard to work. Adding an entry for this laptop to the
>> override_table makes the internal keyboard functional.
>>
>> v2: Rebase onto linux-next
>
> Hans, any comments?

No comments, the patch looks good to me:

Reviewed-by: Hans de Goede <[email protected]>

Regards,

Hans





>
>> Signed-off-by: Werner Sembach <[email protected]>
>> Cc: <[email protected]>
>> ---
>> drivers/acpi/resource.c | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
>> index 18f6353c142e..15a3bdbd0755 100644
>> --- a/drivers/acpi/resource.c
>> +++ b/drivers/acpi/resource.c
>> @@ -497,6 +497,18 @@ static const struct dmi_system_id irq1_edge_low_force_override[] = {
>> DMI_MATCH(DMI_BOARD_NAME, "GMxRGxx"),
>> },
>> },
>> + {
>> + /* TongFang GMxXGxx/TUXEDO Polaris 15 Gen5 AMD */
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_NAME, "GMxXGxx"),
>> + },
>> + },
>> + {
>> + /* TongFang GM6XGxX/TUXEDO Stellaris 16 Gen5 AMD */
>> + .matches = {
>> + DMI_MATCH(DMI_BOARD_NAME, "GM6XGxX"),
>> + },
>> + },
>> {
>> /* MAINGEAR Vector Pro 2 15 */
>> .matches = {
>> --
>> 2.34.1
>>
>

2023-10-18 11:00:51

by Rafael J. Wysocki

Subject: Re: [PATCH v2] ACPI: resource: Do IRQ override on TongFang GMxXGxx

On Mon, Oct 16, 2023 at 8:38 PM Hans de Goede <[email protected]> wrote:
>
> Hi,
>
> On 10/16/23 19:33, Rafael J. Wysocki wrote:
> > On Mon, Oct 16, 2023 at 6:08 PM Werner Sembach <[email protected]> wrote:
> >>
> >> The TongFang GMxXGxx/TUXEDO Stellaris/Pollaris Gen5 needs IRQ overriding
> >> for the keyboard to work. Adding an entry for this laptop to the
> >> override_table makes the internal keyboard functional.
> >>
> >> v2: Rebase onto linux-next
> >
> > Hans, any comments?
>
> No comments, the patch looks good to me:
>
> Reviewed-by: Hans de Goede <[email protected]>

Applied as 6.7 material, thanks!