2023-04-11 18:41:24

by Paul Menzel

Subject: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA

Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
ActiveLow while the kernel overrides it to Edge_High.

$ sudo dmesg | grep DMI
DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
$ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
IRQ (Level, ActiveLow, Exclusive, )
{1}

This prevents the keyboard from working. To fix this issue, add this laptop
to the skip_override_table so that the kernel does not override IRQ 1.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
Cc: [email protected]
Cc: Tamim Khan <[email protected]>
Signed-off-by: Paul Menzel <[email protected]>
---
drivers/acpi/resource.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index a222bda7e15b..cade3a9e38bb 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
},
},
+ {
+ .ident = "Asus ExpertBook B1502CBA",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
+ DMI_MATCH(DMI_BOARD_NAME, "B1502CBA"),
+ },
+ },
{
.ident = "Asus ExpertBook B2402CBA",
.matches = {
--
2.40.0

2023-04-11 18:57:33

by Rafael J. Wysocki

Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA

On Tue, Apr 11, 2023 at 8:32 PM Paul Menzel <[email protected]> wrote:
>
> Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
> ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
>
> $ sudo dmesg | grep DMI
> DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
> $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
> IRQ (Level, ActiveLow, Exclusive, )
> {1}
>
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
> Cc: [email protected]
> Cc: Tamim Khan <[email protected]>
> Signed-off-by: Paul Menzel <[email protected]>
> ---
> drivers/acpi/resource.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index a222bda7e15b..cade3a9e38bb 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -432,6 +432,13 @@ static const struct dmi_system_id asus_laptop[] = {
> DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"),
> },
> },
> + {
> + .ident = "Asus ExpertBook B1502CBA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_BOARD_NAME, "B1502CBA"),
> + },
> + },
> {
> .ident = "Asus ExpertBook B2402CBA",
> .matches = {
> --

Applied as 6.3-rc material, thanks!

2023-04-12 13:58:53

by Paul Menzel

Subject: Re: [PATCH] ACPI: resource: Skip IRQ override on ASUS ExpertBook B1502CBA

Dear Linux folks,


Just for the record, I am adding the Tested-by line. Lorenzo tried to
send it themselves, but even text/plain were rejected by LKML as they
are using Yahoo Mail.

[email protected]>: host 23.128.96.18[23.128.96.18]
said: 553 5.7.1
Hello [23.128.96.19], for your MAIL FROM address
<[email protected]> policy
analysis reported: Your address is not liked source for email
(in reply to
MAIL FROM command)

Am 11.04.23 um 20:31 schrieb Paul Menzel:
> Like the ASUS ExpertBook B2502CBA and various ASUS Vivobook laptops, the
> ASUS ExpertBook B1502CBA has an ACPI DSDT table that describes IRQ 1 as
> ActiveLow while the kernel overrides it to Edge_High.
>
> $ sudo dmesg | grep DMI
> DMI: ASUSTeK COMPUTER INC. ASUS EXPERTBOOK B1502CBA_B1502CBA/B1502CBA, BIOS B1502CBA.300 01/18/2023
> $ grep -A 40 PS2K dsdt.dsl | grep IRQ -A 1
> IRQ (Level, ActiveLow, Exclusive, )
> {1}
>
> This prevents the keyboard from working. To fix this issue, add this laptop
> to the skip_override_table so that the kernel does not override IRQ 1.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217323
> Cc: [email protected]
> Cc: Tamim Khan <[email protected]>
> Signed-off-by: Paul Menzel <[email protected]>

Tested-by: Lorenzo Grasso <[email protected]>

[…]


Kind regards,

Paul