2023-01-06 01:15:03

by Yang Li

Subject: [PATCH -next] thermal: Fix unsigned comparison with less than zero

The return value from the call to intel_tcc_get_tjmax() is int, which can
be a negative error code. However, the return value is being assigned to
an u32 variable 'tj_max', so making 'tj_max' an int.

Eliminate the following warning:
./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING: Unsigned expression compared with zero: tj_max < 0

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c b/drivers/thermal/intel/intel_soc_dts_iosf.c
index 2138693d8afd..8c26f7b2316b 100644
--- a/drivers/thermal/intel/intel_soc_dts_iosf.c
+++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
@@ -380,7 +380,7 @@ struct intel_soc_dts_sensors *intel_soc_dts_iosf_init(
{
struct intel_soc_dts_sensors *sensors;
bool notification;
- u32 tj_max;
+ int tj_max;
int ret;
int i;

--
2.20.1.7.g153144c

2023-01-06 07:30:20

by Zhang, Rui

Subject: Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero

On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> The return value from the call to intel_tcc_get_tjmax() is int, which
> can
> be a negative error code. However, the return value is being assigned
> to
> an u32 variable 'tj_max', so making 'tj_max' an int.
>
> Eliminate the following warning:
> ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> Unsigned expression compared with zero: tj_max < 0
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Thanks for catching this issue.

Acked-by: Zhang Rui <[email protected]>

thanks,
rui

> ---
> drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> b/drivers/thermal/intel/intel_soc_dts_iosf.c
> index 2138693d8afd..8c26f7b2316b 100644
> --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> *intel_soc_dts_iosf_init(
> {
> struct intel_soc_dts_sensors *sensors;
> bool notification;
> - u32 tj_max;
> + int tj_max;
> int ret;
> int i;
>

2023-01-12 19:57:02

by Rafael J. Wysocki

Subject: Re: [PATCH -next] thermal: Fix unsigned comparison with less than zero

On Fri, Jan 6, 2023 at 8:03 AM Zhang, Rui <[email protected]> wrote:
>
> On Fri, 2023-01-06 at 08:59 +0800, Yang Li wrote:
> > The return value from the call to intel_tcc_get_tjmax() is int, which
> > can
> > be a negative error code. However, the return value is being assigned
> > to
> > an u32 variable 'tj_max', so making 'tj_max' an int.
> >
> > Eliminate the following warning:
> > ./drivers/thermal/intel/intel_soc_dts_iosf.c:394:5-11: WARNING:
> > Unsigned expression compared with zero: tj_max < 0
> >
> > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3637
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Thanks for catching this issue.
>
> Acked-by: Zhang Rui <[email protected]>

Applied, thanks!

> > ---
> > drivers/thermal/intel/intel_soc_dts_iosf.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > index 2138693d8afd..8c26f7b2316b 100644
> > --- a/drivers/thermal/intel/intel_soc_dts_iosf.c
> > +++ b/drivers/thermal/intel/intel_soc_dts_iosf.c
> > @@ -380,7 +380,7 @@ struct intel_soc_dts_sensors
> > *intel_soc_dts_iosf_init(
> > {
> > struct intel_soc_dts_sensors *sensors;
> > bool notification;
> > - u32 tj_max;
> > + int tj_max;
> > int ret;
> > int i;
> >