2024-02-27 15:58:15

by Stefan Hajnoczi

Subject: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()

virtio_fs_sysfs_exit() is called by:
- static int __init virtio_fs_init(void)
- static void __exit virtio_fs_exit(void)

Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
an __exit function.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Stefan Hajnoczi <[email protected]>
---
fs/fuse/virtio_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 62a44603740c..948b49c2460d 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void)
return 0;
}

-static void __exit virtio_fs_sysfs_exit(void)
+static void virtio_fs_sysfs_exit(void)
{
kset_unregister(virtio_fs_kset);
virtio_fs_kset = NULL;
--
2.43.2

2024-02-28 04:50:52

by Randy Dunlap

Subject: Re: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()

On 2/27/24 07:57, Stefan Hajnoczi wrote:
> virtio_fs_sysfs_exit() is called by:
> - static int __init virtio_fs_init(void)
> - static void __exit virtio_fs_exit(void)
>
> Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
> an __exit function.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Stefan Hajnoczi <[email protected]>


Reviewed-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]> # build-tested

Thanks.

> ---
> fs/fuse/virtio_fs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 62a44603740c..948b49c2460d 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -1588,7 +1588,7 @@ static int __init virtio_fs_sysfs_init(void)
> return 0;
> }
>
> -static void __exit virtio_fs_sysfs_exit(void)
> +static void virtio_fs_sysfs_exit(void)
> {
> kset_unregister(virtio_fs_kset);
> virtio_fs_kset = NULL;

--
#Randy

2024-02-28 07:37:32

by Miklos Szeredi

Subject: Re: [PATCH] virtiofs: drop __exit from virtio_fs_sysfs_exit()

On Tue, 27 Feb 2024 at 23:31, Randy Dunlap <[email protected]> wrote:
>
>
>
> On 2/27/24 07:57, Stefan Hajnoczi wrote:
> > virtio_fs_sysfs_exit() is called by:
> > - static int __init virtio_fs_init(void)
> > - static void __exit virtio_fs_exit(void)
> >
> > Remove __exit from virtio_fs_sysfs_exit() since virtio_fs_init() is not
> > an __exit function.
> >
> > Reported-by: kernel test robot <[email protected]>
> > Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> > Signed-off-by: Stefan Hajnoczi <[email protected]>
>
>
> Reviewed-by: Randy Dunlap <[email protected]>
> Tested-by: Randy Dunlap <[email protected]> # build-tested

Applied, thanks.

Miklos