2019-08-19 05:50:45

by Vasily Averin

Subject: [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()

Currently fuse_writepages_fill() calls get_fuse_inode() few times with
the same argument.

Signed-off-by: Vasily Averin <[email protected]>
---
fs/fuse/file.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index e076c2cf65b0..bc9b64ef7b5d 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1874,7 +1874,7 @@ static int fuse_writepages_fill(struct page *page,

if (!data->ff) {
err = -EIO;
- data->ff = fuse_write_file_get(fc, get_fuse_inode(inode));
+ data->ff = fuse_write_file_get(fc, fi);
if (!data->ff)
goto out_unlock;
}
@@ -1919,8 +1919,6 @@ static int fuse_writepages_fill(struct page *page,
* under writeback, so we can release the page lock.
*/
if (data->req == NULL) {
- struct fuse_inode *fi = get_fuse_inode(inode);
-
err = -ENOMEM;
req = fuse_request_alloc_nofs(FUSE_REQ_INLINE_PAGES);
if (!req) {
--
2.17.1

2019-10-03 08:21:56

by Miklos Szeredi

Subject: Re: [PATCH] fuse: redundant get_fuse_inode() calls in fuse_writepages_fill()

On Mon, Aug 19, 2019 at 7:48 AM Vasily Averin <[email protected]> wrote:
>
> Currently fuse_writepages_fill() calls get_fuse_inode() few times with
> the same argument.

Thanks, applied.

Miklos