2022-12-13 12:49:53

by zyfjeff

Subject: [PATCH] fuse: remove duplicate check for nodeid

before this check, the nodeid has already been checked once, so
the check here doesn't make an sense, so remove the check for
nodeid here.

if (err || !outarg->nodeid)
goto out_put_forget;

err = -EIO;
>>> if (!outarg->nodeid)
goto out_put_forget;

Signed-off-by: zyfjeff <[email protected]>
---
fs/fuse/dir.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c
index cd1a071b625a..a33cd1131640 100644
--- a/fs/fuse/dir.c
+++ b/fs/fuse/dir.c
@@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name
goto out_put_forget;

err = -EIO;
- if (!outarg->nodeid)
- goto out_put_forget;
if (fuse_invalid_attr(&outarg->attr))
goto out_put_forget;

--
2.34.0

2023-02-01 15:34:14

by Miklos Szeredi

Subject: Re: [PATCH] fuse: remove duplicate check for nodeid

On Tue, 13 Dec 2022 at 12:52, zyfjeff <[email protected]> wrote:
>
> before this check, the nodeid has already been checked once, so
> the check here doesn't make an sense, so remove the check for
> nodeid here.
>
> if (err || !outarg->nodeid)
> goto out_put_forget;
>
> err = -EIO;
> >>> if (!outarg->nodeid)
> goto out_put_forget;
>
> Signed-off-by: zyfjeff <[email protected]>

Applied, thanks.

Miklos