dyndbg will next need zs_malloc and friends, so add config reqs now,
to avoid touching make-deps late in a patch-set.
I used select in order not to hide dyndbg inadvertently.
I want to say recommends, since it could be an optional feature.
Whats the best way ?
Signed-off-by: Jim Cromie <[email protected]>
---
lib/Kconfig.debug | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 9ad9210d70a1..a7973063baf0 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -100,6 +100,7 @@ config DYNAMIC_DEBUG
depends on PRINTK
depends on (DEBUG_FS || PROC_FS)
select DYNAMIC_DEBUG_CORE
+ select ZPOOL
help
Compiles debug level messages into the kernel, which would not
--
2.26.2
On 8/7/20 1:09 PM, Jim Cromie wrote:
> dyndbg will next need zs_malloc and friends, so add config reqs now,
> to avoid touching make-deps late in a patch-set.
>
> I used select in order not to hide dyndbg inadvertently.
> I want to say recommends, since it could be an optional feature.
> Whats the best way ?
Hi Jim,
Can you elaborate on what/why/when it could be an optional feature?
>
> Signed-off-by: Jim Cromie <[email protected]>
> ---
> lib/Kconfig.debug | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 9ad9210d70a1..a7973063baf0 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -100,6 +100,7 @@ config DYNAMIC_DEBUG
> depends on PRINTK
> depends on (DEBUG_FS || PROC_FS)
> select DYNAMIC_DEBUG_CORE
> + select ZPOOL
> help
>
> Compiles debug level messages into the kernel, which would not
>
--
~Randy
On Sat, Aug 8, 2020 at 11:06 PM Randy Dunlap <[email protected]> wrote:
>
> On 8/7/20 1:09 PM, Jim Cromie wrote:
> > dyndbg will next need zs_malloc and friends, so add config reqs now,
> > to avoid touching make-deps late in a patch-set.
> >
> > I used select in order not to hide dyndbg inadvertently.
> > I want to say recommends, since it could be an optional feature.
> > Whats the best way ?
>
> Hi Jim,
> Can you elaborate on what/why/when it could be an optional feature?
>
hi Randy,
I dont think making it optional adds any real value.
if ZPOOL/ZRAM/ZSWAP is not included, we dont get any of
that sweet sweet compression. or the off-lining of >1/2 the memory.
I've got 46 callsites enabled atm, which is more than average, ~3100
callsites offlined.
This is the payoff for the added complexity and memory (the site pointer)
fwiw, Im not entirely clear on which of ZPOOL/ZRAM/ZSWAP
is the correct dependency/ies. ZSWAP feels like the best destination
for the data,
especially if the data can be pushed aggressively into it.