2020-05-28 20:27:02

by Peter Zijlstra

[permalink] [raw]
Subject: [PATCH 0/6] x86/entry: disallow #DB more

These patches disallow #DB during NMI/#MC and allow removing a lot of fugly code.

Patch #6 should probably wait until we've got the KGDB situation sorted
because applying that makes a bad situation worse.



2020-05-28 22:46:25

by Lai Jiangshan

[permalink] [raw]
Subject: Re: [PATCH 0/6] x86/entry: disallow #DB more

On Fri, May 29, 2020 at 4:25 AM Peter Zijlstra <[email protected]> wrote:
>
> These patches disallow #DB during NMI/#MC and allow removing a lot of fugly code.
>

Hello

Will #DB be allowed in #DF?

Thanks
Lai

> Patch #6 should probably wait until we've got the KGDB situation sorted
> because applying that makes a bad situation worse.
>
>

2020-05-28 22:53:00

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH 0/6] x86/entry: disallow #DB more

On Fri, May 29, 2020 at 06:42:46AM +0800, Lai Jiangshan wrote:
> On Fri, May 29, 2020 at 4:25 AM Peter Zijlstra <[email protected]> wrote:
> >
> > These patches disallow #DB during NMI/#MC and allow removing a lot of fugly code.
> >
>
> Hello
>
> Will #DB be allowed in #DF?

No, that whole thing is noinstr.

2020-05-28 23:08:40

by Lai Jiangshan

[permalink] [raw]
Subject: Re: [PATCH 0/6] x86/entry: disallow #DB more

On Fri, May 29, 2020 at 6:48 AM Peter Zijlstra <[email protected]> wrote:
>
> On Fri, May 29, 2020 at 06:42:46AM +0800, Lai Jiangshan wrote:
> > On Fri, May 29, 2020 at 4:25 AM Peter Zijlstra <[email protected]> wrote:
> > >
> > > These patches disallow #DB during NMI/#MC and allow removing a lot of fugly code.
> > >
> >
> > Hello
> >
> > Will #DB be allowed in #DF?
>
> No, that whole thing is noinstr.

But it calls many functions, including die(), panic().
We don't want #DB to interfere how it die() and panic().
Since it is in fragile #DF, the #DB may mess it up and
make #DF fails to report and die.

2020-05-29 08:03:53

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH 0/6] x86/entry: disallow #DB more

On Fri, May 29, 2020 at 07:05:54AM +0800, Lai Jiangshan wrote:
> On Fri, May 29, 2020 at 6:48 AM Peter Zijlstra <[email protected]> wrote:
> >
> > On Fri, May 29, 2020 at 06:42:46AM +0800, Lai Jiangshan wrote:
> > > On Fri, May 29, 2020 at 4:25 AM Peter Zijlstra <[email protected]> wrote:
> > > >
> > > > These patches disallow #DB during NMI/#MC and allow removing a lot of fugly code.
> > > >
> > >
> > > Hello
> > >
> > > Will #DB be allowed in #DF?
> >
> > No, that whole thing is noinstr.
>
> But it calls many functions, including die(), panic().
> We don't want #DB to interfere how it die() and panic().
> Since it is in fragile #DF, the #DB may mess it up and
> make #DF fails to report and die.

The only recoverable #DF is the ESPFIX shit. If we do not take that,
we're on the way to panic(), I really can't be arsed if you crash the
box before that, we're going to die anyway.