2022-06-12 10:19:34

by sunliming

Subject: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page_type()

The variable 'type' in split_page_type() is set but not used, so remove
it.

Fixes the following w1 warning:

arch/x86/kvm/mmu/mmu.c:982:28: warning: variable 'type' set but not used [-Wunused-but-set-variable]

Reported-by: kernel test robot <[email protected]>
Signed-off-by: sunliming <[email protected]>
---
arch/x86/kvm/mmu/mmu.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
index 7b3df91a93cf..f4d577335f94 100644
--- a/arch/x86/kvm/mmu/mmu.c
+++ b/arch/x86/kvm/mmu/mmu.c
@@ -979,14 +979,12 @@ static void split_page_type(gfn_t gfn, struct kvm_memory_slot *slot,
enum pg_level level)
{
struct kvm_page_attr *page_attr = page_attr_slot(gfn, slot, level);
- enum kvm_page_type type;
gfn_t base_gfn;

if (WARN_ON_ONCE(!kvm_page_type_valid(page_attr) || level <= PG_LEVEL_4K))
return;

base_gfn = gfn & ~(KVM_PAGES_PER_HPAGE(level) - 1);
- type = page_attr->type;

/*
* Set the type to KVM_PAGE_TYPE_MIXED in advance since when a large
--
2.25.1

2022-06-13 03:28:34

by Xiaoyao Li

Subject: Re: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page_type()

On 6/12/2022 11:56 AM, sunliming wrote:
> The variable 'type' in split_page_type() is set but not used, so remove
> it.
>
> Fixes the following w1 warning:
>
> arch/x86/kvm/mmu/mmu.c:982:28: warning: variable 'type' set but not used [-Wunused-but-set-variable]

Please note, the code doesn't get into upstream yet.

The fix shouldn't be sent to upstream maillist.

> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: sunliming <[email protected]>
> ---
> arch/x86/kvm/mmu/mmu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index 7b3df91a93cf..f4d577335f94 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -979,14 +979,12 @@ static void split_page_type(gfn_t gfn, struct kvm_memory_slot *slot,
> enum pg_level level)
> {
> struct kvm_page_attr *page_attr = page_attr_slot(gfn, slot, level);
> - enum kvm_page_type type;
> gfn_t base_gfn;
>
> if (WARN_ON_ONCE(!kvm_page_type_valid(page_attr) || level <= PG_LEVEL_4K))
> return;
>
> base_gfn = gfn & ~(KVM_PAGES_PER_HPAGE(level) - 1);
> - type = page_attr->type;
>
> /*
> * Set the type to KVM_PAGE_TYPE_MIXED in advance since when a large

2022-06-14 01:07:05

by sunliming

Subject: Re: [PATCH] KVM: x86/mmu: Remove unused "type" of split_page_type()

I got it, I am sorry aboot it , thanks.

Xiaoyao Li <[email protected]> 于2022年6月13日周一 10:48写道：

>
> On 6/12/2022 11:56 AM, sunliming wrote:
> > The variable 'type' in split_page_type() is set but not used, so remove
> > it.
> >
> > Fixes the following w1 warning:
> >
> > arch/x86/kvm/mmu/mmu.c:982:28: warning: variable 'type' set but not used [-Wunused-but-set-variable]
>
> Please note, the code doesn't get into upstream yet.
>
> The fix shouldn't be sent to upstream maillist.
>
> > Reported-by: kernel test robot <[email protected]>
> > Signed-off-by: sunliming <[email protected]>
> > ---
> > arch/x86/kvm/mmu/mmu.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> > index 7b3df91a93cf..f4d577335f94 100644
> > --- a/arch/x86/kvm/mmu/mmu.c
> > +++ b/arch/x86/kvm/mmu/mmu.c
> > @@ -979,14 +979,12 @@ static void split_page_type(gfn_t gfn, struct kvm_memory_slot *slot,
> > enum pg_level level)
> > {
> > struct kvm_page_attr *page_attr = page_attr_slot(gfn, slot, level);
> > - enum kvm_page_type type;
> > gfn_t base_gfn;
> >
> > if (WARN_ON_ONCE(!kvm_page_type_valid(page_attr) || level <= PG_LEVEL_4K))
> > return;
> >
> > base_gfn = gfn & ~(KVM_PAGES_PER_HPAGE(level) - 1);
> > - type = page_attr->type;
> >
> > /*
> > * Set the type to KVM_PAGE_TYPE_MIXED in advance since when a large
>