2022-03-23 19:51:07

by Yuntao Wang

Subject: [PATCH bpf-next] bpf: Remove redundant assignment to smap->map.value_size

The attr->value_size is already assigned to smap->map.value_size
in bpf_map_init_from_attr(), there is no need to do it again in
stack_map_alloc()

Signed-off-by: Yuntao Wang <[email protected]>
---
kernel/bpf/stackmap.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
index 34725bfa1e97..6131b4a19572 100644
--- a/kernel/bpf/stackmap.c
+++ b/kernel/bpf/stackmap.c
@@ -106,7 +106,6 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr)
return ERR_PTR(-ENOMEM);

bpf_map_init_from_attr(&smap->map, attr);
- smap->map.value_size = value_size;
smap->n_buckets = n_buckets;

err = get_callchain_buffers(sysctl_perf_event_max_stack);
--
2.35.0.rc2

2022-03-24 15:52:16

by Joanne Koong

Subject: Re: [PATCH bpf-next] bpf: Remove redundant assignment to smap->map.value_size

On Wed, Mar 23, 2022 at 2:21 AM Yuntao Wang <[email protected]> wrote:
>
> The attr->value_size is already assigned to smap->map.value_size
> in bpf_map_init_from_attr(), there is no need to do it again in
> stack_map_alloc()
>
> Signed-off-by: Yuntao Wang <[email protected]>

LGTM.
Acked-by: Joanne Koong <[email protected]>

> ---
> kernel/bpf/stackmap.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/bpf/stackmap.c b/kernel/bpf/stackmap.c
> index 34725bfa1e97..6131b4a19572 100644
> --- a/kernel/bpf/stackmap.c
> +++ b/kernel/bpf/stackmap.c
> @@ -106,7 +106,6 @@ static struct bpf_map *stack_map_alloc(union bpf_attr *attr)
> return ERR_PTR(-ENOMEM);
>
> bpf_map_init_from_attr(&smap->map, attr);
> - smap->map.value_size = value_size;
> smap->n_buckets = n_buckets;
>
> err = get_callchain_buffers(sysctl_perf_event_max_stack);
> --
> 2.35.0.rc2
>

2022-04-05 03:27:58

by patchwork-bot+netdevbpf

Subject: Re: [PATCH bpf-next] bpf: Remove redundant assignment to smap->map.value_size

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <[email protected]>:

On Wed, 23 Mar 2022 15:36:26 +0800 you wrote:
> The attr->value_size is already assigned to smap->map.value_size
> in bpf_map_init_from_attr(), there is no need to do it again in
> stack_map_alloc()
>
> Signed-off-by: Yuntao Wang <[email protected]>
> ---
> kernel/bpf/stackmap.c | 1 -
> 1 file changed, 1 deletion(-)

Here is the summary with links:
- [bpf-next] bpf: Remove redundant assignment to smap->map.value_size
https://git.kernel.org/bpf/bpf-next/c/8eb943fc5e5f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html