2021-08-05 19:57:01

by Christophe JAILLET

Subject: [PATCH] RDMA/rtrs: Remove a useless kfree

'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing
it. It is just a no-op.

Remove the useless kfree.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index ece3205531b8..fc440a08e112 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con,
}

if (!sess->rbufs) {
- kfree(sess->rbufs);
sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs),
GFP_KERNEL);
if (!sess->rbufs)
--
2.30.2

2021-08-06 10:11:33

by Haris Iqbal

Subject: Re: [PATCH] RDMA/rtrs: Remove a useless kfree

On Thu, Aug 5, 2021 at 7:43 PM Christophe JAILLET
<[email protected]> wrote:
>
> 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing
> it. It is just a no-op.
>
> Remove the useless kfree.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Thanks
Acked-by: Md Haris Iqbal <[email protected]>

> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index ece3205531b8..fc440a08e112 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -1844,7 +1844,6 @@ static int rtrs_rdma_conn_established(struct rtrs_clt_con *con,
> }
>
> if (!sess->rbufs) {
> - kfree(sess->rbufs);
> sess->rbufs = kcalloc(queue_depth, sizeof(*sess->rbufs),
> GFP_KERNEL);
> if (!sess->rbufs)
> --
> 2.30.2
>

2021-08-19 14:32:11

by Jason Gunthorpe

Subject: Re: [PATCH] RDMA/rtrs: Remove a useless kfree

On Thu, Aug 05, 2021 at 07:43:36PM +0200, Christophe JAILLET wrote:
> 'sess->rbufs' is known to be NULL here, so there is no point in kfree'ing
> it. It is just a no-op.
>
> Remove the useless kfree.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> Acked-by: Md Haris Iqbal <[email protected]>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 1 -
> 1 file changed, 1 deletion(-)

Applied to for-next with a Fixes line, thanks

Jason