2020-03-26 20:37:39

by Doug Smythies

Subject: [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header

If the --quiet option is not used, turbostat prints a useful system
configuration header during startup. Inclusion of idle system configuration
information is a function of inclusion in the columns choosen to be displayed.

Always list the idle system configuration.

Signed-off-by: Doug Smythies <[email protected]>
---
tools/power/x86/turbostat/turbostat.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 33b370865d16..834b86676d00 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -3530,9 +3530,6 @@ dump_sysfs_cstate_config(void)
int state;
char *sp;

- if (!DO_BIC(BIC_sysfs))
- return;
-
if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
fprintf(outf, "cpuidle not loaded\n");
return;
--
2.25.1

2020-08-13 21:18:23

by Len Brown

Subject: Re: [PATCH] tools/power/x86/turbostat: Always print idle in the system configuration header

Applied.

thanks!
-Len

On Thu, Mar 26, 2020 at 4:36 PM Doug Smythies <[email protected]> wrote:
>
> If the --quiet option is not used, turbostat prints a useful system
> configuration header during startup. Inclusion of idle system configuration
> information is a function of inclusion in the columns choosen to be displayed.
>
> Always list the idle system configuration.
>
> Signed-off-by: Doug Smythies <[email protected]>
> ---
> tools/power/x86/turbostat/turbostat.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 33b370865d16..834b86676d00 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c
> @@ -3530,9 +3530,6 @@ dump_sysfs_cstate_config(void)
> int state;
> char *sp;
>
> - if (!DO_BIC(BIC_sysfs))
> - return;
> -
> if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
> fprintf(outf, "cpuidle not loaded\n");
> return;
> --
> 2.25.1
>


--
Len Brown, Intel Open Source Technology Center