2024-04-17 05:36:38

by wangyao

Subject: [PATCH] modules: Drop the .export_symbol section from the final modules

From: Wang Yao <[email protected]>

Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
forget drop the .export_symbol section from the final modules.

Signed-off-by: Wang Yao <[email protected]>
---
scripts/module.lds.S | 1 +
1 file changed, 1 insertion(+)

diff --git a/scripts/module.lds.S b/scripts/module.lds.S
index bf5bcf2836d8..89ff01a22634 100644
--- a/scripts/module.lds.S
+++ b/scripts/module.lds.S
@@ -13,6 +13,7 @@ SECTIONS {
/DISCARD/ : {
*(.discard)
*(.discard.*)
+ *(.export_symbol)
}

__ksymtab 0 : { *(SORT(___ksymtab+*)) }
--
2.27.0

2024-04-22 02:03:18

by Ainux Wang

Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules

Hi, everyone:
Could someone review this patch?
Best regards,
Ainux Wang.

<[email protected]> 于2024年4月17日周三 13:35写道：
>
> From: Wang Yao <[email protected]>
>
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
>
> Signed-off-by: Wang Yao <[email protected]>
> ---
> scripts/module.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
> /DISCARD/ : {
> *(.discard)
> *(.discard.*)
> + *(.export_symbol)
> }
>
> __ksymtab 0 : { *(SORT(___ksymtab+*)) }
> --
> 2.27.0
>

2024-05-07 05:16:16

by Ainux Wang

Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules

Hi, everyone:

Could someone review this patch?

Best regards,
Ainux Wang.

<[email protected]> 于2024年4月17日周三 13:35写道：

>
> From: Wang Yao <[email protected]>
>
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
>
> Signed-off-by: Wang Yao <[email protected]>
> ---
> scripts/module.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
> /DISCARD/ : {
> *(.discard)
> *(.discard.*)
> + *(.export_symbol)
> }
>
> __ksymtab 0 : { *(SORT(___ksymtab+*)) }
> --
> 2.27.0
>

2024-05-11 01:04:02

by Ainux Wang

Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules

Hi, everyone:

Could someone help to review this patch?

Best regards,
Ainux Wang.


Ainux Wang <[email protected]> 于2024年5月7日周二 13:15写道：
>
> Hi, everyone:
>
> Could someone review this patch?
>
> Best regards,
> Ainux Wang.
>
> <[email protected]> 于2024年4月17日周三 13:35写道：
>
> >
> > From: Wang Yao <[email protected]>
> >
> > Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> > forget drop the .export_symbol section from the final modules.
> >
> > Signed-off-by: Wang Yao <[email protected]>
> > ---
> > scripts/module.lds.S | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> > index bf5bcf2836d8..89ff01a22634 100644
> > --- a/scripts/module.lds.S
> > +++ b/scripts/module.lds.S
> > @@ -13,6 +13,7 @@ SECTIONS {
> > /DISCARD/ : {
> > *(.discard)
> > *(.discard.*)
> > + *(.export_symbol)
> > }
> >
> > __ksymtab 0 : { *(SORT(___ksymtab+*)) }
> > --
> > 2.27.0
> >

2024-05-11 22:42:09

by Luis Chamberlain

Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules

On Wed, Apr 17, 2024 at 01:35:30PM +0800, [email protected] wrote:
> From: Wang Yao <[email protected]>
>
> Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> forget drop the .export_symbol section from the final modules.
>
> Signed-off-by: Wang Yao <[email protected]>

Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
modpost") was your change, wanna address / take it through your
tree? It makes sense to me though.

Luis

> ---
> scripts/module.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> index bf5bcf2836d8..89ff01a22634 100644
> --- a/scripts/module.lds.S
> +++ b/scripts/module.lds.S
> @@ -13,6 +13,7 @@ SECTIONS {
> /DISCARD/ : {
> *(.discard)
> *(.discard.*)
> + *(.export_symbol)
> }
>
> __ksymtab 0 : { *(SORT(___ksymtab+*)) }
> --
> 2.27.0
>

2024-05-13 23:11:33

by Masahiro Yamada

Subject: Re: [PATCH] modules: Drop the .export_symbol section from the final modules

On Sun, May 12, 2024 at 7:42 AM Luis Chamberlain <[email protected]> wrote:
>
> On Wed, Apr 17, 2024 at 01:35:30PM +0800, [email protected] wrote:
> > From: Wang Yao <[email protected]>
> >
> > Commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by modpost")
> > forget drop the .export_symbol section from the final modules.
> >
> > Signed-off-by: Wang Yao <[email protected]>
>
> Masahiro, commit ddb5cdbafaaa ("kbuild: generate KSYMTAB entries by
> modpost") was your change, wanna address / take it through your
> tree? It makes sense to me though.


Yes, applied now.

Thanks for the reminder.





>
> Luis
>
> > ---
> > scripts/module.lds.S | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/module.lds.S b/scripts/module.lds.S
> > index bf5bcf2836d8..89ff01a22634 100644
> > --- a/scripts/module.lds.S
> > +++ b/scripts/module.lds.S
> > @@ -13,6 +13,7 @@ SECTIONS {
> > /DISCARD/ : {
> > *(.discard)
> > *(.discard.*)
> > + *(.export_symbol)
> > }
> >
> > __ksymtab 0 : { *(SORT(___ksymtab+*)) }
> > --
> > 2.27.0
> >



--
Best Regards
Masahiro Yamada